* [PATCH RESEND 3/7] watchdog: mv64x60_wdt: use devm_ioremap()
@ 2013-04-29 9:35 Jingoo Han
2013-04-29 17:55 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Jingoo Han @ 2013-04-29 9:35 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Wim Van Sebroeck', linux-watchdog,
Jingoo Han
Use devm_ioremap() to make cleanup paths simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/watchdog/mv64x60_wdt.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/mv64x60_wdt.c b/drivers/watchdog/mv64x60_wdt.c
index c7fb878..e4cf980 100644
--- a/drivers/watchdog/mv64x60_wdt.c
+++ b/drivers/watchdog/mv64x60_wdt.c
@@ -276,7 +276,7 @@ static int mv64x60_wdt_probe(struct platform_device *dev)
if (!r)
return -ENODEV;
- mv64x60_wdt_regs = ioremap(r->start, resource_size(r));
+ mv64x60_wdt_regs = devm_ioremap(&dev->dev, r->start, resource_size(r));
if (mv64x60_wdt_regs == NULL)
return -ENOMEM;
@@ -293,8 +293,6 @@ static int mv64x60_wdt_remove(struct platform_device *dev)
mv64x60_wdt_handler_disable();
- iounmap(mv64x60_wdt_regs);
-
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND 3/7] watchdog: mv64x60_wdt: use devm_ioremap()
2013-04-29 9:35 Jingoo Han
@ 2013-04-29 17:55 ` Guenter Roeck
2013-04-30 1:56 ` Jingoo Han
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2013-04-29 17:55 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', linux-kernel, 'Wim Van Sebroeck',
linux-watchdog
On Mon, Apr 29, 2013 at 06:35:15PM +0900, Jingoo Han wrote:
> Use devm_ioremap() to make cleanup paths simpler.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
This patch also addresses the missing call to iounmap() if the call
to misc_register fails.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/mv64x60_wdt.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/mv64x60_wdt.c b/drivers/watchdog/mv64x60_wdt.c
> index c7fb878..e4cf980 100644
> --- a/drivers/watchdog/mv64x60_wdt.c
> +++ b/drivers/watchdog/mv64x60_wdt.c
> @@ -276,7 +276,7 @@ static int mv64x60_wdt_probe(struct platform_device *dev)
> if (!r)
> return -ENODEV;
>
> - mv64x60_wdt_regs = ioremap(r->start, resource_size(r));
> + mv64x60_wdt_regs = devm_ioremap(&dev->dev, r->start, resource_size(r));
> if (mv64x60_wdt_regs == NULL)
> return -ENOMEM;
>
> @@ -293,8 +293,6 @@ static int mv64x60_wdt_remove(struct platform_device *dev)
>
> mv64x60_wdt_handler_disable();
>
> - iounmap(mv64x60_wdt_regs);
> -
> return 0;
> }
>
> --
> 1.7.2.5
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND 3/7] watchdog: mv64x60_wdt: use devm_ioremap()
2013-04-29 17:55 ` Guenter Roeck
@ 2013-04-30 1:56 ` Jingoo Han
2013-04-30 1:58 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Jingoo Han @ 2013-04-30 1:56 UTC (permalink / raw)
To: 'Guenter Roeck'
Cc: 'Andrew Morton', linux-kernel, 'Wim Van Sebroeck',
linux-watchdog, Jingoo Han
On Tuesday, April 30, 2013 2:55 AM, Guenter Roeck wrote:
> On Mon, Apr 29, 2013 at 06:35:15PM +0900, Jingoo Han wrote:
> > Use devm_ioremap() to make cleanup paths simpler.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> This patch also addresses the missing call to iounmap() if the call
> to misc_register fails.
When devm_ioremap() is used, there is no need to call devm_iounmap().
It is because, these resource managed functions such as
devm_ioremap() allow the driver core to automatically
clean up any allocation, when probe function fails.
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Thank you for your reviewing.
Best regards,
Jingoo Han
>
> > ---
> > drivers/watchdog/mv64x60_wdt.c | 4 +---
> > 1 files changed, 1 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/watchdog/mv64x60_wdt.c b/drivers/watchdog/mv64x60_wdt.c
> > index c7fb878..e4cf980 100644
> > --- a/drivers/watchdog/mv64x60_wdt.c
> > +++ b/drivers/watchdog/mv64x60_wdt.c
> > @@ -276,7 +276,7 @@ static int mv64x60_wdt_probe(struct platform_device *dev)
> > if (!r)
> > return -ENODEV;
> >
> > - mv64x60_wdt_regs = ioremap(r->start, resource_size(r));
> > + mv64x60_wdt_regs = devm_ioremap(&dev->dev, r->start, resource_size(r));
> > if (mv64x60_wdt_regs == NULL)
> > return -ENOMEM;
> >
> > @@ -293,8 +293,6 @@ static int mv64x60_wdt_remove(struct platform_device *dev)
> >
> > mv64x60_wdt_handler_disable();
> >
> > - iounmap(mv64x60_wdt_regs);
> > -
> > return 0;
> > }
> >
> > --
> > 1.7.2.5
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND 3/7] watchdog: mv64x60_wdt: use devm_ioremap()
2013-04-30 1:56 ` Jingoo Han
@ 2013-04-30 1:58 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2013-04-30 1:58 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', linux-kernel, 'Wim Van Sebroeck',
linux-watchdog
On Tue, Apr 30, 2013 at 10:56:39AM +0900, Jingoo Han wrote:
> On Tuesday, April 30, 2013 2:55 AM, Guenter Roeck wrote:
> > On Mon, Apr 29, 2013 at 06:35:15PM +0900, Jingoo Han wrote:
> > > Use devm_ioremap() to make cleanup paths simpler.
> > >
> > > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> >
> > This patch also addresses the missing call to iounmap() if the call
> > to misc_register fails.
>
> When devm_ioremap() is used, there is no need to call devm_iounmap().
>
> It is because, these resource managed functions such as
> devm_ioremap() allow the driver core to automatically
> clean up any allocation, when probe function fails.
>
Same response as before. Please read my note above. It says clearly
"this patch _addresses_ ...", not "this patch _creates_ ...".
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH RESEND 3/7] watchdog: mv64x60_wdt: use devm_ioremap()
@ 2013-05-02 5:51 Jingoo Han
0 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-05-02 5:51 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Wim Van Sebroeck', linux-watchdog,
'Guenter Roeck', Jingoo Han
Use devm_ioremap() to make cleanup paths simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/watchdog/mv64x60_wdt.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/mv64x60_wdt.c b/drivers/watchdog/mv64x60_wdt.c
index c7fb878..e4cf980 100644
--- a/drivers/watchdog/mv64x60_wdt.c
+++ b/drivers/watchdog/mv64x60_wdt.c
@@ -276,7 +276,7 @@ static int mv64x60_wdt_probe(struct platform_device *dev)
if (!r)
return -ENODEV;
- mv64x60_wdt_regs = ioremap(r->start, resource_size(r));
+ mv64x60_wdt_regs = devm_ioremap(&dev->dev, r->start, resource_size(r));
if (mv64x60_wdt_regs == NULL)
return -ENOMEM;
@@ -293,8 +293,6 @@ static int mv64x60_wdt_remove(struct platform_device *dev)
mv64x60_wdt_handler_disable();
- iounmap(mv64x60_wdt_regs);
-
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-02 5:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-02 5:51 [PATCH RESEND 3/7] watchdog: mv64x60_wdt: use devm_ioremap() Jingoo Han
-- strict thread matches above, loose matches on Subject: below --
2013-04-29 9:35 Jingoo Han
2013-04-29 17:55 ` Guenter Roeck
2013-04-30 1:56 ` Jingoo Han
2013-04-30 1:58 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox