From: "Johnny.Chuang" <johnny.chuang@emc.com.tw>
To: "'Dmitry Torokhov'" <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
STRD2-莊佳霖 <johnny.chuang@emc.com.tw>,
STRD2-蔡惠嬋 <jennifer.tsai@emc.com.tw>
Cc: STRD2-陳崇明經理 <james.chen@emc.com.tw>,
'梁博翔' <paul.liang@emc.com.tw>, 'jeff' <jeff.chuang@emc.com.tw>
Subject: [PATCH] Input: elants_i2c - return real value of elants_i2c_initialize()
Date: Wed, 28 Aug 2019 10:33:46 +0800 [thread overview]
Message-ID: <000601d55d49$05878160$10968420$@emc.com.tw> (raw)
In-Reply-To: <1566958886-25756-1-git-send-email-johnny.chuang@emc.com.tw>
The return value of elants_i2c_initialize() was always 0.
It maybe register input device when initialize fail.
Signed-off-by: Johnny Chuang <johnny.chuang@emc.com.tw>
---
drivers/input/touchscreen/elants_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/elants_i2c.c
b/drivers/input/touchscreen/elants_i2c.c
index d4ad24e..9c9816f 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -571,7 +571,7 @@ static int elants_i2c_initialize(struct elants_data *ts)
if (error)
ts->iap_mode = ELAN_IAP_RECOVERY;
- return 0;
+ return error;
}
/*
--
2.7.4
next parent reply other threads:[~2019-08-28 2:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1566958886-25756-1-git-send-email-johnny.chuang@emc.com.tw>
2019-08-28 2:33 ` Johnny.Chuang [this message]
2019-08-29 18:29 ` [PATCH] Input: elants_i2c - return real value of elants_i2c_initialize() 'Dmitry Torokhov'
2019-09-03 2:33 ` Johnny.Chuang
2019-09-03 15:55 ` 'Dmitry Torokhov'
2019-09-04 9:51 ` Johnny.Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000601d55d49$05878160$10968420$@emc.com.tw' \
--to=johnny.chuang@emc.com.tw \
--cc=dmitry.torokhov@gmail.com \
--cc=james.chen@emc.com.tw \
--cc=jeff.chuang@emc.com.tw \
--cc=jennifer.tsai@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.liang@emc.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox