From: Chao Yu <chao2.yu@samsung.com>
To: ??? <jaegeuk.kim@samsung.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
谭姝 <shu.tan@samsung.com>
Subject: [f2fs-dev] [PATCH] f2fs: check all ones or zeros bitmap with integer data type for better mount performance
Date: Tue, 22 Oct 2013 17:28:18 +0800 [thread overview]
Message-ID: <000701cecf09$2b2a2280$817e6780$@samsung.com> (raw)
Previously, check_block_count check valid_map with bit data type in common
scenario that sit has all ones or zeros bitmap, it makes low mount
performance.
So let's check the special bitmap with integer data type instead of the bit
one.
Signed-off-by: Tan Shu <shu.tan@samsung.com>
Signed-off-by: Yu Chao <chao2.yu@samsung.com>
---
fs/f2fs/segment.h | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index 7f94d78..d43ab9f 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -543,6 +543,7 @@ static inline void check_block_count(struct f2fs_sb_info
*sbi,
{
struct f2fs_sm_info *sm_info = SM_I(sbi);
unsigned int end_segno = sm_info->segment_count - 1;
+ int *valid_map = (int *)raw_sit->valid_map;
int valid_blocks = 0;
int i;
@@ -552,6 +553,19 @@ static inline void check_block_count(struct
f2fs_sb_info *sbi,
/* check boundary of a given segment number */
BUG_ON(segno > end_segno);
+ /* check all ones or zeros valid_map */
+ if (GET_SIT_VBLOCKS(raw_sit) == 0) {
+ for (i = 0; i < SIT_VBLOCK_MAP_SIZE / sizeof(int); i++)
+ if (unlikely(valid_map[i] != 0))
+ BUG();
+ return;
+ } else if (GET_SIT_VBLOCKS(raw_sit) == sbi->blocks_per_seg) {
+ for (i = 0; i < SIT_VBLOCK_MAP_SIZE / sizeof(int); i++)
+ if (unlikely(valid_map[i] != -1))
+ BUG();
+ return;
+ }
+
/* check bitmap with valid block count */
for (i = 0; i < sbi->blocks_per_seg; i++)
if (f2fs_test_bit(i, raw_sit->valid_map))
---
next reply other threads:[~2013-10-22 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 9:28 Chao Yu [this message]
2013-10-22 12:23 ` [f2fs-dev] [PATCH] f2fs: check all ones or zeros bitmap with integer data type for better mount performance Jaegeuk Kim
2013-10-23 3:23 ` Chao Yu
2013-10-23 9:32 ` Jaegeuk Kim
2013-10-24 3:28 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000701cecf09$2b2a2280$817e6780$@samsung.com' \
--to=chao2.yu@samsung.com \
--cc=jaegeuk.kim@samsung.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shu.tan@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox