* RE: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
[not found] <1440634906-16103-1-git-send-email-xerofoify@gmail.com>
@ 2015-08-27 14:14 ` Steve Wise
0 siblings, 0 replies; only message in thread
From: Steve Wise @ 2015-08-27 14:14 UTC (permalink / raw)
To: 'Nicholas Krause'
Cc: dledford, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel
> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@gmail.com]
> Sent: Wednesday, August 26, 2015 7:22 PM
> To: swise@chelsio.com
> Cc: dledford@redhat.com; sean.hefty@intel.com; hal.rosenstock@gmail.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
>
> This fixes the incorrect return statement in the function
> c4iw_reject_cr that returns the value zero directly to instead
> return the variable err as this function can fail when called
> and if so we will incorrectly return success rather then the
> correct status of a failed call to the caller of this particular
> function.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
NAK.
The return code for these cpl handlers indicates if process_work() or other callers needs to free the skb. They are supposed to
return 0.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-08-27 14:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1440634906-16103-1-git-send-email-xerofoify@gmail.com>
2015-08-27 14:14 ` [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr Steve Wise
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox