From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752810AbbH0OOp (ORCPT ); Thu, 27 Aug 2015 10:14:45 -0400 Received: from smtp.opengridcomputing.com ([72.48.136.20]:39062 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752033AbbH0OOo (ORCPT ); Thu, 27 Aug 2015 10:14:44 -0400 From: "Steve Wise" To: "'Nicholas Krause'" Cc: , , , , References: <1440634906-16103-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1440634906-16103-1-git-send-email-xerofoify@gmail.com> Subject: RE: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr Date: Thu, 27 Aug 2015 09:14:47 -0500 Message-ID: <000801d0e0d2$bb99b0b0$32cd1210$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQH/Mbs4M+D0ZlmsVzec1CTFipj0rp3DQTXQ Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Nicholas Krause [mailto:xerofoify@gmail.com] > Sent: Wednesday, August 26, 2015 7:22 PM > To: swise@chelsio.com > Cc: dledford@redhat.com; sean.hefty@intel.com; hal.rosenstock@gmail.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr > > This fixes the incorrect return statement in the function > c4iw_reject_cr that returns the value zero directly to instead > return the variable err as this function can fail when called > and if so we will incorrectly return success rather then the > correct status of a failed call to the caller of this particular > function. > > Signed-off-by: Nicholas Krause > --- NAK. The return code for these cpl handlers indicates if process_work() or other callers needs to free the skb. They are supposed to return 0.