From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D5502E88A9 for ; Fri, 27 Jun 2025 17:07:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751044062; cv=none; b=kya80uO9pomOeii+2CQWepaN/+9Hc+WGZ9EjR8qEoRS+MageW0OZSqbya9NxUKbuFlPcRMym9VK5j+BTBXYKMkWcOQiRjZrWo92EoiLnBuK0NZRcVpwA4epkIaEEmsAFh8o84Hdg3QRd8bQYiwosX8+dRz23eWBYl8LDW94bY2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751044062; c=relaxed/simple; bh=fozUXgzdys12L7XIOaNewlTS0SdNY9+9Qgo5gNsnZe4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BzDNrMIoc0xLkex9C058eexIPCHY0Obi7dz9OxdnsahTOmEMW1jyt/MSoXaqS3H5Z8dd0SFjacOzjATbrVCGx4yczJcwcFb+e1PVs/uADzezILx2M07ZTvmLU5QaN2vv+LkL/Ae0kx0XDy0jSlMdj0eQ/E2BZfwiiohmoQmSKhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=R0alO3p3; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R0alO3p3" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-450cb2ddd46so13247355e9.2 for ; Fri, 27 Jun 2025 10:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751044057; x=1751648857; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uICgYiY+G3JspFAyT3xgva3fPY2F/XGPfCaGX5O6oEY=; b=R0alO3p3hTdZr06m1pakC61V9Fk97rsWGw+bKG7oKLjYCn141+UYLbJ7bkxjxeNAP3 TrDgMAdUpBexc7N5Qcjuj8lfkar9dyTEhC7ipMGWaAwSshiz1r1De9RgTcqLcoEIRZpN iLDG2w9Nj0KrjHQraZdkvIeCnTpV518lZXhX7v1dJAhdPbByu+C0HQ7cGmJundfFvrrg FVdOPrL2ZcsUC7Nc7BukLLyFa9Xqu34j22gQG1jD8Ta5aacd5/j3TjzzdXlFy94XdDBw Y9C4Ok7b3ZV8dqSCqJ7S9KkOASjqbBJXw0pq6jzqFcIYyHo8JJ1s42M3tGmQAUyTOzmi l4jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751044057; x=1751648857; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uICgYiY+G3JspFAyT3xgva3fPY2F/XGPfCaGX5O6oEY=; b=jng6NDv/2zTnyAVAWsp87vY8vXwPtuT1Awon9jh2Xt1FIt2phwE/YrRKxRXxveb5P9 8FkPwKDe9JrxQwHjR8fe4EWEsOAe/xaKc/JM0VfUmaTcQChmjzBPUncgS4cBapkpXRAd 8m4JNDo1/HZmjyCKEhkDKlTL6yoAB/LODE2zI7//K2QFdQw4vCnADNmkAY2OrAbV3/lZ e2QQ3ekAPlHkcDiPt6f2QdR4wqHmzlI1c5grusvYAkZNUd1tG006SzbL3SM3lRB5gQT0 nHV6g8Vv91NcjJ/fQ1LYcZUsifp9E1WhGFkQ080j21IcNBELg0NHP9FKdFNSJ2buM8IK 1clQ== X-Forwarded-Encrypted: i=1; AJvYcCUDBKB0RCP9rR4N0fWiQyO39g3lVcWXxyqNvcClBuL9zsZ8E4lNuom6GVQpfoewf8PfagRYMuwplsuyNCM=@vger.kernel.org X-Gm-Message-State: AOJu0YxzSk+IpcgUys5g2ciswDhm0tnuaHLr8TwUhjRXcl65p8bGZ4Xn mVbt9eR/Xd2Fg5UgfpAWQM6HWetQZmyf5GD3fx05VqRQ9+8fLG8V5+CiheaiovpdpA4= X-Gm-Gg: ASbGncv/tNj5bT9Ia8/Qk7wXiv0EtF70sSRNO3aUnmfgK9RlsGeCbB38mNo0STti7U4 oqKPtZ82lxlKJamCXd0YEnEc58wGDBqPaV/zq3NjFpxyr51KrkifucS8JMtoz8HXswAp6cjaLLZ 16JR7e5PhhTBcaTnIHxJEVzqxP9yPcALMOQNdxhjQ+KOK5TQ2MOKUOsth95vBdQP6eevN/H78HQ /16qGJcAPkOmkExuoz/cT1IbqEFWUMe4DZo4RcSm5WTdbc8gU8qLZtn2foGlfw05GUAuMuOcVLP wk3cZBJSlIsHKMAIluMOrYFVCprO/lqWMduWf5qJJCCx6mFfoP33dGRtXPwTVrg4+FedWTbvrCy MCW501oZbKHVIVf65+1xRbln+WCI= X-Google-Smtp-Source: AGHT+IH31SkLI3Vsbb2Y9EKuOMKX6EReaApoDazwONmaL3DKqX/243XHNKIPxGCAkbSxqfNRW2Vmuw== X-Received: by 2002:a05:600c:198a:b0:442:ccf9:e6f2 with SMTP id 5b1f17b1804b1-4538ee7df15mr52309315e9.16.1751044057276; Fri, 27 Jun 2025 10:07:37 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538a3fe0efsm55339995e9.24.2025.06.27.10.07.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 10:07:36 -0700 (PDT) Message-ID: <000a9208-4a4d-458c-bf28-de4b10ed0678@linaro.org> Date: Fri, 27 Jun 2025 18:07:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] media: iris: select appropriate DMA device for internal buffers To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250627-video_cb-v3-0-51e18c0ffbce@quicinc.com> <20250627-video_cb-v3-4-51e18c0ffbce@quicinc.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250627-video_cb-v3-4-51e18c0ffbce@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27/06/2025 16:48, Vikash Garodia wrote: > When a non-pixel device (np_dev) exists, it is preferred for DMA > operations for internal buffers which are specific to bitstream data > processing. DPB(decoded picture buffer) buffers are internal buffers > associated with pixel buffers, hence they are not part of "non_pixel" > device. > > Signed-off-by: Vikash Garodia > --- > drivers/media/platform/qcom/iris/iris_buffer.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c > index e5c5a564fcb81e77746df8c4797a10a07f2ae946..0bf6041936175d03a51985be148e78894fc3e990 100644 > --- a/drivers/media/platform/qcom/iris/iris_buffer.c > +++ b/drivers/media/platform/qcom/iris/iris_buffer.c > @@ -265,6 +265,7 @@ static int iris_create_internal_buffer(struct iris_inst *inst, > struct iris_buffers *buffers = &inst->buffers[buffer_type]; > struct iris_core *core = inst->core; > struct iris_buffer *buffer; > + struct device *dev; > > if (!buffers->size) > return 0; > @@ -280,7 +281,11 @@ static int iris_create_internal_buffer(struct iris_inst *inst, > buffer->dma_attrs = DMA_ATTR_WRITE_COMBINE | DMA_ATTR_NO_KERNEL_MAPPING; > list_add_tail(&buffer->list, &buffers->list); > > - buffer->kvaddr = dma_alloc_attrs(core->dev, buffer->buffer_size, > + dev = core->np_dev ? core->np_dev : core->dev; > + if (buffer->type == BUF_DPB) > + dev = core->dev; > + > + buffer->kvaddr = dma_alloc_attrs(dev, buffer->buffer_size, > &buffer->device_addr, GFP_KERNEL, buffer->dma_attrs); > if (!buffer->kvaddr) > return -ENOMEM; > @@ -367,9 +372,15 @@ int iris_queue_internal_buffers(struct iris_inst *inst, u32 plane) > int iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffer *buffer) > { > struct iris_core *core = inst->core; > + struct device *dev; > + > + dev = core->np_dev ? core->np_dev : core->dev; > + > + if (buffer->type == BUF_DPB) > + dev = core->dev; Again I think the hooking of dev is clearer with if/else instead of ternary operators. Its not against the coding standard to my knowledge .. > > list_del(&buffer->list); > - dma_free_attrs(core->dev, buffer->buffer_size, buffer->kvaddr, > + dma_free_attrs(dev, buffer->buffer_size, buffer->kvaddr, > buffer->device_addr, buffer->dma_attrs); > kfree(buffer); > > Reviewed-by: Bryan O'Donoghue