Re: [PATCH v2] mmc: dw_mmc: Make sure we don't get stuck when we get an error

Ulf Hansson
2014-08-13T15:04:32Z

On 13 August 2014 15:38, Doug Anderson <dianders@chromium.org> wrote:
> Hi,
>
> On Wed, May 21, 2014 at 2:08 AM, Seungwon Jeon <tgih.jun@samsung.com> wrote:
>> On Wed, May 21, 2014, Doug Anderson wrote:
>>> If we happened to get a data error at just the wrong time the dw_mmc
>>> driver could get into a state where it would never complete its
>>> request. That would leave the caller just hanging there.
>>>
>>> We fix this two ways and both of the two fixes on their own appear to
>>> fix the problems we've seen:
>>>
>>> 1. Fix a race in the tasklet where the interrupt setting the data
>>> error happens _just after_ we check for it, then we get a
>>> EVENT_XFER_COMPLETE. We fix this by repeating a bit of code.
>>> 2. Fix it so that if we detect that we've got an error in the "data
>>> busy" state and we're not going to do anything else we end the
>>> request and unblock anyone waiting.
>>>
>>> Signed-off-by: Doug Anderson <dianders@chromium.org>
>>> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>
>>
>> It will be applied after "mmc: dw_mmc: change to use recommended reset procedure"
>>
>> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
>>
>> Thanks,
>> Seungwon Jeon
>
> I saw that Ulf applied "mmc: dw_mmc: change to use recommended reset
> procedure". Could we apply this one now, too? Do you want me to
> repost?

Please repost and rebase if needed.

Kind regards
Uffe
>
> -Doug