public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pankaj Dubey <pankaj.dubey@samsung.com>
To: "'Greg KH'" <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, naushad@samsung.com
Subject: RE: [PATCH] kobject: fix NULL pointer derefernce in kobj_child_ns_ops
Date: Fri, 26 Sep 2014 08:52:12 +0530	[thread overview]
Message-ID: <000c01cfd939$17523320$45f69960$@samsung.com> (raw)
In-Reply-To: <20140925104512.GC28590@kroah.com>

Hi Greg,

On Thursday, September 25, 2014 4:15 PM, Greg KH wrote,
> To: Pankaj Dubey
> Cc: linux-kernel@vger.kernel.org; naushad@samsung.com
> Subject: Re: [PATCH] kobject: fix NULL pointer derefernce in
kobj_child_ns_ops
> 
> On Wed, Sep 24, 2014 at 04:25:54PM +0530, Pankaj Dubey wrote:
> > We will hit NULL pointer dereference if we call
> > platform_device_register_simple or platform_device_add at very early
> > stage. I have observed following crash when called platform_device_add
> > from "init_irq" hook of machine_desc. This patch fixes this issue and
> > let system handle this case gracefully instead of kernel panic.
> 
> Is there any in-tree code that needs this "fix"?  Or can it wait for 3.18?
> 

Even though I am not completely sure, at least I could not see any in-tree
code
which may need this fix.
I posted this fix, because while working on one of syscon patch [1] I wanted
to call
"platform_device_add" in one of APIs which may get called during very early
stage
of system boot, and during that time it will lead to kernel panic.

But mine syscon related patch is still under review, so I think this patch
can wait
for 3.18.

[1]: https://lkml.org/lkml/2014/9/22/12

Thanks,
Pankaj Dubey


> thanks,
> 
> greg k-h


      reply	other threads:[~2014-09-26  3:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 10:55 [PATCH] kobject: fix NULL pointer derefernce in kobj_child_ns_ops Pankaj Dubey
2014-09-25 10:45 ` Greg KH
2014-09-26  3:22   ` Pankaj Dubey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000c01cfd939$17523320$45f69960$@samsung.com' \
    --to=pankaj.dubey@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naushad@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox