From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbeEUMfQ (ORCPT ); Mon, 21 May 2018 08:35:16 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57976 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751109AbeEUMfN (ORCPT ); Mon, 21 May 2018 08:35:13 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E290860131 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=ilialin@codeaurora.org From: To: "'Russell King - ARM Linux'" Cc: , , , , , , , References: <1526555955-29960-11-git-send-email-ilialin@codeaurora.org> <1526898690-4018-1-git-send-email-ilialin@codeaurora.org> <20180521105428.GM17671@n2100.armlinux.org.uk> <000b01d3f0f3$aa961cc0$ffc25640$@codeaurora.org> <20180521121140.GO17671@n2100.armlinux.org.uk> In-Reply-To: <20180521121140.GO17671@n2100.armlinux.org.uk> Subject: RE: [PATCH] cpufreq: Add Kryo CPU scaling driver Date: Mon, 21 May 2018 15:35:07 +0300 Message-ID: <000d01d3f100$294247e0$7bc6d7a0$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQF4oTaoNxz6XIk2qh8MCLQUCquwggKwu+X3AuWN43cB2ygHZQHn9PLypKXxQQA= Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are 2 CPU clusters in the Kryo, CPU 0 and 1 are called Silver Cluster and CPU 2 and 3 - Gold Cluster. Each cluster has single clock. The clusters differ in terms of speed capabilities, computing power and power consumption. Therefore, I define separate OPP table for each cluster, and my driver will choose the appropriate OPP subset for each cluster. Lead refers to first CPU in the cluster. > -----Original Message----- > From: Russell King - ARM Linux > Sent: Monday, May 21, 2018 15:12 > To: ilialin@codeaurora.org > Cc: viresh.kumar@linaro.org; devicetree@vger.kernel.org; linux- > pm@vger.kernel.org; linux-arm-msm@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-soc@vger.kernel.org; linux- > clk@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver > > On Mon, May 21, 2018 at 02:05:41PM +0300, ilialin@codeaurora.org wrote: > > You are right. > > cpu_dev_silver != cpu_dev_gold, and I found this with my tests as well. > > Thank you. > > > > > -----Original Message----- > > > From: Russell King - ARM Linux > > > Sent: Monday, May 21, 2018 13:54 > > > To: Ilia Lin > > > Cc: viresh.kumar@linaro.org; devicetree@vger.kernel.org; linux- > > > pm@vger.kernel.org; linux-arm-msm@vger.kernel.org; linux- > > > kernel@vger.kernel.org; linux-soc@vger.kernel.org; linux- > > > clk@vger.kernel.org; linux-arm-kernel@lists.infradead.org > > > Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver > > > > > > On Mon, May 21, 2018 at 01:31:30PM +0300, Ilia Lin wrote: > > > > +#define SILVER_LEAD 0 > > > > +#define GOLD_LEAD 2 > > > > > > Okay, two different values here, but "GOLD_LEAD" appears unused. > > > > > > > + cpu_dev_silver = get_cpu_device(SILVER_LEAD); > > > > + if (NULL == cpu_dev_silver) > > > > + return -ENODEV; > > > > + > > > > + cpu_dev_gold = get_cpu_device(SILVER_LEAD); > > > > + if (NULL == cpu_dev_gold) > > > > + return -ENODEV; > > > > > > get_cpu_device() takes the logical CPU number. So the above gets > > > CPU 0 each time, and so cpu_dev_silver == cpu_dev_gold here. So > > > what's the point of the second get_cpu_device() ? If it's supposed to be: > > > > > > cpu_dev_gold = get_cpu_device(GOLD_LEAD); > > > > > > That would get CPU 2, but in terms of these defines, it doesn't make > > > that much sense. What exactly does "silver lead" and "gold lead" > > > refer to in > > these > > > definitions? > > I think you still need to explain this. > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps > up According to speedtest.net: 8.21Mbps down 510kbps up