From: "Christopher S. Aker" <caker@theshore.net>
To: "Jens Axboe" <axboe@suse.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.10-rc2-bk7 - Badness in cfq_put_request at drivers/block/cfq-iosched.c:1402
Date: Wed, 24 Nov 2004 13:29:24 -0600 [thread overview]
Message-ID: <000f01c4d25b$e8d497c0$0201a8c0@hawk> (raw)
In-Reply-To: 20041124134038.GF13847@suse.de
> Can you try this simple check to see if it triggers anything?
>
> ===== cfq-iosched.c 1.13 vs edited =====
> --- 1.13/drivers/block/cfq-iosched.c 2004-10-30 01:35:21 +02:00
> +++ edited/cfq-iosched.c 2004-11-24 14:40:13 +01:00
> @@ -1389,6 +1389,8 @@
> struct cfq_data *cfqd = q->elevator->elevator_data;
> struct cfq_rq *crq = RQ_DATA(rq);
>
> + WARN_ON(!spin_is_locked(q->queue_lock));
> +
> if (crq) {
> struct cfq_queue *cfqq = crq->cfq_queue;
I'd be happy to, but I won't have a free machine for a couple of days. I'll can
probably give it a shot during the weekend...
-Chris
next prev parent reply other threads:[~2004-11-24 21:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-24 7:24 2.6.10-rc2-bk7 - Badness in cfq_put_request at drivers/block/cfq-iosched.c:1402 Christopher S. Aker
2004-11-24 13:01 ` Jens Axboe
2004-11-24 13:24 ` Jens Axboe
2004-11-24 13:38 ` Christopher S. Aker
2004-11-24 13:40 ` Jens Axboe
2004-11-24 19:29 ` Christopher S. Aker [this message]
2004-11-25 18:43 ` Jens Axboe
2004-11-26 7:43 ` Jens Axboe
2004-11-26 8:07 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000f01c4d25b$e8d497c0$0201a8c0@hawk' \
--to=caker@theshore.net \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox