public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Timothy Miller" <tmiller10@cfl.rr.com>
To: <linux-kernel@vger.kernel.org>
Subject: Ah!  Found a bug in radeonfb.c!
Date: Fri, 12 Mar 2004 01:33:01 -0500	[thread overview]
Message-ID: <001101c407fb$de49c9e0$6401a8c0@epimetheus> (raw)

I was WONDERING why certain things would get corrupted on the screen when
using the radeon framebuffer driver.  I've been seeing a number of
off-by-one errors.

First of all, the kernel source I'm looking at is 2.4.22-gentoo-r7.

Anyhow, here's the deal.  Look at the function 'fbcon_radeon_bmove'.  I'm
having to type this in by hand due to circumstances, so, here's something
that looks vaguely like a patch but which will require people to actually
look at (I've never submitted a patch before, so let's just discuss it
first):

line 4399:
    if (srcy < dsty) {
-        srcy += height;
-        dsty += height;
+        srcy += height-1;
+        dsty += height-1;
    } else


line 4404:
    if (srcx < dstx) {
-        srcx += width;
-        dstx += width;
+        srcx += width-1;
+        dstx += width-1;
    }






                 reply	other threads:[~2004-03-12  6:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001101c407fb$de49c9e0$6401a8c0@epimetheus' \
    --to=tmiller10@cfl.rr.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox