* Ah! Found a bug in radeonfb.c!
@ 2004-03-12 6:33 Timothy Miller
0 siblings, 0 replies; only message in thread
From: Timothy Miller @ 2004-03-12 6:33 UTC (permalink / raw)
To: linux-kernel
I was WONDERING why certain things would get corrupted on the screen when
using the radeon framebuffer driver. I've been seeing a number of
off-by-one errors.
First of all, the kernel source I'm looking at is 2.4.22-gentoo-r7.
Anyhow, here's the deal. Look at the function 'fbcon_radeon_bmove'. I'm
having to type this in by hand due to circumstances, so, here's something
that looks vaguely like a patch but which will require people to actually
look at (I've never submitted a patch before, so let's just discuss it
first):
line 4399:
if (srcy < dsty) {
- srcy += height;
- dsty += height;
+ srcy += height-1;
+ dsty += height-1;
} else
line 4404:
if (srcx < dstx) {
- srcx += width;
- dstx += width;
+ srcx += width-1;
+ dstx += width-1;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-03-12 6:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-12 6:33 Ah! Found a bug in radeonfb.c! Timothy Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox