[PATCH] power: replace strict_strtoul() with kstrtoul()

[PATCH] power: replace strict_strtoul() with kstrtoul()

[Jingoo Han]

The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/power/ab8500_fg.c        |    4 ++--
 drivers/power/pcf50633-charger.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
index c5391f5..6207b5e 100644
--- a/drivers/power/ab8500_fg.c
+++ b/drivers/power/ab8500_fg.c
@@ -2467,7 +2467,7 @@ static ssize_t charge_full_store(struct ab8500_fg *di, const char *buf,
 	unsigned long charge_full;
 	ssize_t ret = -EINVAL;
 
-	ret = strict_strtoul(buf, 10, &charge_full);
+	ret = kstrtoul(buf, 10, &charge_full);
 
 	dev_dbg(di->dev, "Ret %zd charge_full %lu", ret, charge_full);
 
@@ -2489,7 +2489,7 @@ static ssize_t charge_now_store(struct ab8500_fg *di, const char *buf,
 	unsigned long charge_now;
 	ssize_t ret;
 
-	ret = strict_strtoul(buf, 10, &charge_now);
+	ret = kstrtoul(buf, 10, &charge_now);
 
 	dev_dbg(di->dev, "Ret %zd charge_now %lu was %d",
 		ret, charge_now, di->bat_cap.prev_mah);
diff --git a/drivers/power/pcf50633-charger.c b/drivers/power/pcf50633-charger.c
index 17fd77f..92f0ea0 100644
--- a/drivers/power/pcf50633-charger.c
+++ b/drivers/power/pcf50633-charger.c
@@ -191,7 +191,7 @@ static ssize_t set_usblim(struct device *dev,
 	unsigned long ma;
 	int ret;
 
-	ret = strict_strtoul(buf, 10, &ma);
+	ret = kstrtoul(buf, 10, &ma);
 	if (ret)
 		return -EINVAL;
 
@@ -228,7 +228,7 @@ static ssize_t set_chglim(struct device *dev,
 	if (!mbc->pcf->pdata->charger_reference_current_ma)
 		return -ENODEV;
 
-	ret = strict_strtoul(buf, 10, &ma);
+	ret = kstrtoul(buf, 10, &ma);
 	if (ret)
 		return -EINVAL;
 
-- 
1.7.10.4

Re: [PATCH] power: replace strict_strtoul() with kstrtoul()

[Andy Shevchenko]

On Sat, Jun 1, 2013 at 10:27 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.

> --- a/drivers/power/ab8500_fg.c
> +++ b/drivers/power/ab8500_fg.c
> @@ -2467,7 +2467,7 @@ static ssize_t charge_full_store(struct ab8500_fg *di, const char *buf,
>         unsigned long charge_full;
>         ssize_t ret = -EINVAL;

Redundant assignment.

> --- a/drivers/power/pcf50633-charger.c
> +++ b/drivers/power/pcf50633-charger.c
> @@ -191,7 +191,7 @@ static ssize_t set_usblim(struct device *dev,
>         unsigned long ma;
>         int ret;
>
> -       ret = strict_strtoul(buf, 10, &ma);
> +       ret = kstrtoul(buf, 10, &ma);
>         if (ret)
>                 return -EINVAL;

return ret;

> @@ -228,7 +228,7 @@ static ssize_t set_chglim(struct device *dev,
>         if (!mbc->pcf->pdata->charger_reference_current_ma)
>                 return -ENODEV;
>
> -       ret = strict_strtoul(buf, 10, &ma);
> +       ret = kstrtoul(buf, 10, &ma);
>         if (ret)
>                 return -EINVAL;

Ditto.

--
With Best Regards,
Andy Shevchenko