From: Roger Larsson <roger@norran.net>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Confusing comment in reschedule_idle - unlock of runqueue.
Date: Wed, 15 Nov 2000 23:18:42 +0100 [thread overview]
Message-ID: <00111523184200.04121@dox> (raw)
Hi,
This comment is written in head of reschedule_idle, is it really
correct?
--------------------------
/*
* This is ugly, but reschedule_idle() is very timing-critical.
* We enter with the runqueue spinlock held, but we might end
* up unlocking it early, so the caller must not unlock the
* runqueue, it's always done by reschedule_idle().
*
* This function must be inline as anything that saves and restores
* flags has to do so within the same register window on sparc (Anton)
*/
static FASTCALL(void reschedule_idle(struct task_struct * p));
static void reschedule_idle(struct task_struct * p)
--------------------------
If it is then, wake_up_process and schedule_tail are wrong.
But I think not...
--------------------------
reschedule_idle(p);
out:
spin_unlock_irqrestore(&runqueue_lock, flags);
--------------------------
/RogerL
--
Home page:
http://www.norran.net/nra02596/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
reply other threads:[~2000-11-16 21:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00111523184200.04121@dox \
--to=roger@norran.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox