From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751638AbdEaIXk (ORCPT ); Wed, 31 May 2017 04:23:40 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46994 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751520AbdEaIXf (ORCPT ); Wed, 31 May 2017 04:23:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6A2016074A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=fenglinw@codeaurora.org From: "Wu Fenglin" To: "'Pavel Machek'" Cc: , , "'Richard Purdie'" , "'Jacek Anaszewski'" , "'Rob Herring'" , "'Mark Rutland'" , , , , , , References: <20170531061541.10808-1-fenglinw@codeaurora.org> <20170531061541.10808-2-fenglinw@codeaurora.org> <20170531075536.GA13028@amd> In-Reply-To: <20170531075536.GA13028@amd> Subject: RE: [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module Date: Wed, 31 May 2017 16:23:28 +0800 Message-ID: <001301d2d9e7$3102b720$93082560$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJwfOPcu7rQBtY8dIoWKkCUhBP3qwG2rNqNAvqmGmygrUeiQA== Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, Thanks for the reviewing. For the order, the hardware register mapping has this order (blue/green/red) from bit0/1/2, I can revert it to (red/green/blue) if there is a strong concern. For these two properties: qcom,off-ms/ qcom,on-ms, I am using them to assign the default blinking on/off time, then the LEDs would have a default blinking pattern if you do "echo 1 > /sys/class/leds/red/blink" Fenglin Wu -----Original Message----- From: Pavel Machek [mailto:pavel@ucw.cz] Sent: Wednesday, May 31, 2017 3:56 PM To: fenglinw@codeaurora.org Cc: linux-arm-msm@vger.kernel.org; linux-kernel@vger.kernel.org; Richard Purdie ; Jacek Anaszewski ; Rob Herring ; Mark Rutland ; linux-leds@vger.kernel.org; devicetree@vger.kernel.org; subbaram@quicinc.com; aghayal@qti.qualcomm.com; wruan@quicinc.com; kgunda@qti.qualcomm.com Subject: Re: [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module Hi! > +- qcom,support-blink: > + Usage: optional > + Value type: > + Definition: An array of integer values to indicate if "blue", "green", "red" > + LEDs support blink control. The values are listed as the fixed > + order for "blue", "green", "red" LEDs. Normal order is RGB, and no need for the "s. > +- qcom,on-ms: > + Usage: optional > + Value type: > + Definition: An array of time values (milli-seconds) to represent the > + on duration for "blue", "green", "red" LEDs. The values are > + listed as the fixed order for "blue", "green", "red" LEDs. > + This property has to be defined if "qcom,support-blink" is > + present. > + > +- qcom,off-ms: > + Usage: optional > + Value type: > + Definition: An array of time values (milli-seconds) to represent the > + off duration for "blue", "green", "red" LEDs. The values are > + listed as the fixed order for "blue", "green", "red" LEDs. > + This property has to be defined if "qcom,support-blink" is > + present. I don't get it; why is this needed? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html