From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1953CC433DF for ; Mon, 12 Oct 2020 05:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E375E2076E for ; Mon, 12 Oct 2020 05:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726625AbgJLFN5 (ORCPT ); Mon, 12 Oct 2020 01:13:57 -0400 Received: from mga14.intel.com ([192.55.52.115]:24006 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725967AbgJLFN5 (ORCPT ); Mon, 12 Oct 2020 01:13:57 -0400 IronPort-SDR: 7ADqcn1ok1sE6gxqAUEE+ZlRYBjKx3YmtCNLjxnar6tJXiuy5pHh0JM+VdSrs0DdwDLiyGgZTn 8zqZ+YmU8eXg== X-IronPort-AV: E=McAfee;i="6000,8403,9771"; a="164905262" X-IronPort-AV: E=Sophos;i="5.77,365,1596524400"; d="scan'208";a="164905262" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2020 22:13:57 -0700 IronPort-SDR: XIJncUnAd3RoeChaxJorWzxcTwLLSIoVmhAwwlmHM8se+NpLFZWPSyKs3VPtk5ESjbtuhiXdC7 DdEXSY15TSpQ== X-IronPort-AV: E=Sophos;i="5.77,365,1596524400"; d="scan'208";a="355679494" Received: from sdhopkin-mobl.amr.corp.intel.com (HELO [10.254.98.243]) ([10.254.98.243]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2020 22:13:56 -0700 Subject: Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call From: "Kuppuswamy, Sathyanarayanan" To: Sinan Kaya , Bjorn Helgaas Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, Jay Vosburgh References: <20200922233333.GA2239404@bjorn-Precision-5520> <526dc846-b12b-3523-4995-966eb972ceb7@kernel.org> <1fdcc4a6-53b7-2b5f-8496-f0f09405f561@linux.intel.com> <95e23cb5-f6e1-b121-0de8-a2066d507d9c@linux.intel.com> <65238d0b-0a39-400a-3a18-4f68eb554538@kernel.org> <4ae86061-2182-bcf1-ebd7-485acf2d47b9@linux.intel.com> <8beca800-ffb5-c535-6d43-7e750cbf06d0@linux.intel.com> <44f0cac5-8deb-1169-eb6d-93ac4889fe7e@kernel.org> <3bc0fd23-8ddd-32c5-1dd9-4d5209ea68c3@linux.intel.com> <8a3aeb3c-83c4-8626-601d-360946d55dd8@linux.intel.com> <9b295cad-7302-cf2c-d19d-d27fabcb48be@kernel.org> <93b4015f-df2b-728b-3ef7-ac5aa10f03ed@kernel.org> Message-ID: <0013f3d2-569a-27ba-336e-3d4668834545@linux.intel.com> Date: Sun, 11 Oct 2020 22:13:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sinan, On 9/28/20 11:32 AM, Kuppuswamy, Sathyanarayanan wrote: > > > On 9/28/20 11:25 AM, Sinan Kaya wrote: >> On 9/28/2020 2:02 PM, Sinan Kaya wrote: >>> Since there is no state restoration for FATAL errors, I am wondering >>> whether >>> calls to ->error_detected(), ->mmio_enabled() and ->slot_reset() are >>> required? >> >> I also would like to ask someone closer to the spec language double >> check this. >> >> When we recover the link at the end of the DPC handler, what is the >> expected state of the endpoint? >> >> Is it a some kind of a reset like secondary bus reset? (I assumed this >>   one) > I think it will be in reset state. >> >> Undefined? >> >> or just plain link recovery with everything else as intact as it used >> to be? >> > Please check the following version. It should fix most of the reset issues properly. https://lore.kernel.org/linux-pci/5c5bca0bdb958e456176fe6ede10ba8f838fbafc.1602263264.git.sathyanarayanan.kuppuswamy@linux.intel.com/T/#t -- Sathyanarayanan Kuppuswamy Linux Kernel Developer