From: "Kiwoong Kim" <kwmad.kim@samsung.com>
To: "'Bart Van Assche'" <bvanassche@acm.org>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<beanhuo@micron.com>, <adrian.hunter@intel.com>,
<h10.kim@samsung.com>, <hy50.seo@samsung.com>,
<sh425.lee@samsung.com>, <kwangwon.min@samsung.com>,
<junwoo80.lee@samsung.com>, <wkon.kim@samsung.com>
Subject: RE: [PATCH v1] ufs: get target SQ entry within critical section
Date: Mon, 8 Jan 2024 09:51:19 +0900 [thread overview]
Message-ID: <001501da41cc$cb1fbe80$615f3b80$@samsung.com> (raw)
In-Reply-To: <65dead0b-34a5-4e29-83ec-c26e556f262a@acm.org>
> > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> > index 7bc3fc4..da1a9c0 100644
> > --- a/drivers/ufs/core/ufshcd.c
> > +++ b/drivers/ufs/core/ufshcd.c
> > @@ -2199,9 +2199,10 @@ void ufshcd_send_command(struct ufs_hba *hba,
> unsigned int task_tag,
> > if (is_mcq_enabled(hba)) {
> > int utrd_size = sizeof(struct utp_transfer_req_desc);
> > struct utp_transfer_req_desc *src = lrbp->utr_descriptor_ptr;
> > - struct utp_transfer_req_desc *dest = hwq->sqe_base_addr +
> hwq->sq_tail_slot;
> > + struct utp_transfer_req_desc *dest;
> >
> > spin_lock(&hwq->sq_lock);
> > + dest = hwq->sqe_base_addr + hwq->sq_tail_slot;
> > memcpy(dest, src, utrd_size);
> > ufshcd_inc_sq_tail(hwq);
> > spin_unlock(&hwq->sq_lock);
>
> Is this perhaps a duplicate of patch "scsi: ufs: core: Let the sq_lock
> protect sq_tail_slot access"? See also https://lore.kernel.org/linux-
> scsi/1702913550-20631-1-git-send-email-quic_cang@quicinc.com/#t
I didn’t see it. Thank you for letting me know.
prev parent reply other threads:[~2024-01-08 0:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240104012454epcas2p36b58220b4c89ee72f1e095b34d329be2@epcas2p3.samsung.com>
2024-01-04 1:24 ` [PATCH v1] ufs: get target SQ entry within critical section Kiwoong Kim
2024-01-07 16:02 ` Bart Van Assche
2024-01-08 0:51 ` Kiwoong Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001501da41cc$cb1fbe80$615f3b80$@samsung.com' \
--to=kwmad.kim@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=h10.kim@samsung.com \
--cc=hy50.seo@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=junwoo80.lee@samsung.com \
--cc=kwangwon.min@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sh425.lee@samsung.com \
--cc=wkon.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox