Re: [PATCH] Fix for serial.c to work with Xircom Cardbus Ethernet+Modem

["Tom Sightler" <ttsig@tuxyturvy.com>]

>> It seems something changed in 2.4.3-pre7 (against which I applied your
>>  patch) so that it doesn't make a difference. On startup I now get this,
>>  which I am CC:ing as per printk to serial-pci-info@lists.sourceforge.net
>>
>> Mar 24 23:59:05 princess cardmgr[374]: initializing socket 1
>> Mar 24 23:59:05 princess kernel:   got res[10c04000:10c07fff] for
resource 6 of PCI device 115d:0103
>> Mar 24 23:59:05 princess cardmgr[374]: socket 1: Xircom CBEM56G-100
CardBus 10/100 Ethernet + 56K Modem
>> Mar 24 23:59:05 princess kernel: PCI: Enabling device 05:00.1 (0000 ->
0003)
>> Mar 24 23:59:05 princess kernel: Redundant entry in serial pci_table.
Please send the output of
>> Mar 24 23:59:05 princess kernel: lspci -vv, this message
(4445,259,4445,4481)
>> Mar 24 23:59:05 princess kernel: and the manufacturer and name of serial
board or modem board
>> Mar 24 23:59:05 princess kernel: to
serial-pci-info@lists.sourceforge.net.
>> Mar 24 23:59:05 princess kernel: register_serial(): autoconfig failed
>>
>> The card is a Xircom RBEM56G-100, despite what the card advertises.
>>
>> (in case you wonder, cardmgr is from pcmcia_cs-3.1.25).

> OK, I'll take a look at it.  I made the patch against -ac21 which I think
> was only synced up to 2.4.3-pre6, I should have mentioned that.  Perhaps
> someone added the proper Xircom stuff already or some other change made my
> patch irrelavent.  BTW, are you building serial.c as a module, or built
in?
> I have mine as a module so it doesn't load until after the card is
> initialized.  Just curious.

I tested 2.4.3-pre7 and it still fails without my patch.  With my patch I
get the above message about 'Redundant entry in serial pci_table' but it
still manages to setup my serial device as /dev/ttyS4 (the same patch
applied to 2.4.2-ac21 sets the device to /dev/ttyS1).  However it only works
if I load serial.c as a module AFTER the card is inserted, if serial.c is
already loaded it doesn't register correctly with a messages similar to
above.  Perhaps I need to check my hotplug setup.

Could your try serial.c as a module and see if it works for you like that?
That way I'd know I'm on the right track and haven't just found some strange
way to make it work on my system alone.

Later,
Tom