From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933590AbXCEQBo (ORCPT ); Mon, 5 Mar 2007 11:01:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933593AbXCEQBn (ORCPT ); Mon, 5 Mar 2007 11:01:43 -0500 Received: from tcsfw4.tcs-sec.com ([65.127.223.133]:49057 "EHLO tcsfw4.tcs-sec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933587AbXCEQBH (ORCPT ); Mon, 5 Mar 2007 11:01:07 -0500 Reply-To: From: "Venkat Yekkirala" To: "'Eric Paris'" , , Cc: , , "Venkat Yekkirala" , , Subject: RE: [PATCH] xfrm audit hook misplaced in pfkey_delete and xfrm_del_sa Date: Mon, 5 Mar 2007 10:00:51 -0600 Message-ID: <001701c75f3f$73937350$cc0a010a@tcssec.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook CWS, Build 9.0.2416 (9.0.2911.0) Importance: Normal In-Reply-To: <1172866536.31047.32.camel@localhost.localdomain> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1441 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > Inside pfkey_delete and xfrm_del_sa the audit hooks were not called if > there was any permission/security failures in attempting to do the del > operation (such as permission denied from security_xfrm_state_delete). > This patch moves the audit hook to the exit path such that > all failures > (and successes) will actually get audited. Not sure ALL failures are being audited this way elsewhere, but I guess they would catchup in course of time. > > Signed-off-by: Eric Paris Acked-by: Venkat Yekkirala