From: Simon Trimmer <simont@opensource.cirrus.com>
To: 'Lukas Bulwahn' <lukas.bulwahn@gmail.com>,
'Jaroslav Kysela' <perex@perex.cz>,
'Takashi Iwai' <tiwai@suse.com>,
'Richard Fitzgerald' <rf@opensource.cirrus.com>,
<linux-sound@vger.kernel.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ALSA: hda/cs35l56: select intended config FW_CS_DSP
Date: Fri, 9 Feb 2024 11:18:07 +0000 [thread overview]
Message-ID: <001801da5b49$a89be460$f9d3ad20$@opensource.cirrus.com> (raw)
In-Reply-To: <20240209082044.3981-1-lukas.bulwahn@gmail.com>
> -----Original Message-----
> From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>
> Commit 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic
> CS35L56 amplifier") adds configs SND_HDA_SCODEC_CS35L56_{I2C,SPI},
> which selects the non-existing config CS_DSP. Note the renaming in
> commit d7cfdf17cb9d ("firmware: cs_dsp: Rename KConfig symbol CS_DSP ->
> FW_CS_DSP"), though.
>
> Select the intended config FW_CS_DSP.
>
> This broken select command probably was not noticed as the configs also
> select SND_HDA_CS_DSP_CONTROLS and this then selects FW_CS_DSP. So,
> the
> select FW_CS_DSP could actually be dropped, but we will keep this
> redundancy in place as the author originally also intended to have this
> redundancy of selects in place.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Thanks!
Reviewed-by: Simon Trimmer <simont@opensource.cirrus.com>
next prev parent reply other threads:[~2024-02-09 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 8:20 [PATCH] ALSA: hda/cs35l56: select intended config FW_CS_DSP Lukas Bulwahn
2024-02-09 11:18 ` Simon Trimmer [this message]
2024-02-09 12:56 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001801da5b49$a89be460$f9d3ad20$@opensource.cirrus.com' \
--to=simont@opensource.cirrus.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox