From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753211AbcGTDPA (ORCPT ); Tue, 19 Jul 2016 23:15:00 -0400 Received: from cmta4.telus.net ([209.171.16.77]:36572 "EHLO cmta4.telus.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbcGTDO6 (ORCPT ); Tue, 19 Jul 2016 23:14:58 -0400 X-Authority-Analysis: v=2.1 cv=V7WAqrTi c=1 sm=2 tr=0 a=zJWegnE7BH9C0Gl4FFgQyA==:117 a=zJWegnE7BH9C0Gl4FFgQyA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=Pyq9K9CWowscuQLKlpiwfMBGOR0=:19 a=IkcTkHD0fZMA:10 a=QyXUC8HyAAAA:8 a=oSrVrOqfb4RKD3i1rRYA:9 a=QEXdDO2ut3YA:10 a=avl4LiGQNoF5OB0DmCJ7:22 X-Telus-Outbound-IP: 173.180.45.4 From: "Doug Smythies" To: "'Srinivas Pandruvada'" , "'Rafael J. Wysocki'" Cc: "'Linux Kernel Mailing List'" , "'Linux PM list'" References: <3678564.0E838ntcHL@vostro.rjw.lan> <1468967958.2125.2.camel@linux.intel.com> In-Reply-To: <1468967958.2125.2.camel@linux.intel.com> Subject: RE: [PATCH] intel_pstate: Update cpu_frequency tracepoint every time Date: Tue, 19 Jul 2016 20:14:53 -0700 Message-ID: <001a01d1e234$e33ce290$a9b6a7b0$@net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AdHiDnMpO+rEJKjKRm+ZyDsAQEFSdQAJZJMg Content-Language: en-ca Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016.07.19 15:10 Srinivas Pandruvada wrote: > On Tue, 2016-07-19 at 15:10 +0200, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> Currently, intel_pstate only updates the cpu_frequency tracepoint >> if the new P-state to set is different from the current one, but >> that causes powertop to report 100% idle on an 100% loaded system >> sometimes. >> >> Prevent that from happening by updating the cpu_frequency tracepoint >> every time intel_pstate_update_pstate() is called. >> >> Signed-off-by: Rafael J. Wysocki > > Acked-by: Srinivas Pandruvada - Shouldn't this patch refer to: commit fdfdb2b1301670a69195ba1e5666df4a7f02eb46 Author: Rafael J. Wysocki Date: Fri Mar 18 23:20:02 2016 +0100 intel_pstate: Do not call wrmsrl_on_cpu() with disabled interrupts which is the patch that introduced the regression? ... Doug