From: "Manfred Spraul" <manfred@colorfullife.com>
To: "Andrew Morton" <akpm@zip.com.au>
Cc: <linux-kernel@vger.kernel.org>,
"Marcelo Tosatti" <marcelo@conectiva.com.br>
Subject: Re: [patch] block/IDE/interrupt lockup
Date: Sat, 30 Mar 2002 10:35:08 +0100 [thread overview]
Message-ID: <001d01c1d7ce$34f830c0$010411ac@local> (raw)
> - spin_unlock_irq(&io_request_lock);
> + spin_unlock_irqrestore(&io_request_lock, flags);
> rq = kmem_cache_alloc(request_cachep, SLAB_KERNEL);
Great patch.
kmem_cache_alloc with SLAB_KERNEL can sleep, i.e. you've just converted
an obvious bug into a rare, difficult to find bug. What about trying to
fix it?
I agree that this won't happen during boot, but what about a hotplug PCI
ide controller?
--
Manfred
next reply other threads:[~2002-03-30 9:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-30 9:35 Manfred Spraul [this message]
2002-03-30 18:28 ` [patch] block/IDE/interrupt lockup Andrew Morton
2002-03-30 18:52 ` Alan Cox
2002-03-30 19:06 ` Andrew Morton
2002-03-30 23:23 ` Keith Owens
-- strict thread matches above, loose matches on Subject: below --
2002-04-01 9:23 Manfred Spraul
2002-03-30 5:45 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001d01c1d7ce$34f830c0$010411ac@local' \
--to=manfred@colorfullife.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox