From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692Ab3K2Bdq (ORCPT ); Thu, 28 Nov 2013 20:33:46 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:31751 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872Ab3K2Bdm (ORCPT ); Thu, 28 Nov 2013 20:33:42 -0500 X-AuditID: cbfee691-b7f666d0000048b0-e5-5297eeef1ebb From: Jingoo Han To: "'Joe Perches'" , "'Greg Kroah-Hartman'" , "'Bjorn Helgaas'" Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, "'Andrew Morton'" , "'Andy Whitcroft'" , linux-serial@vger.kernel.org, "'Jingoo Han'" References: <000601ceebdc$ee148de0$ca3da9a0$%han@samsung.com> <20131128040750.GA29917@kroah.com> <006001ceebfa$c85a1020$590e3060$%han@samsung.com> <1385617213.12210.5.camel@joe-AO722> <20131128055328.GA565@kroah.com> <1385619863.12210.14.camel@joe-AO722> In-reply-to: <1385619863.12210.14.camel@joe-AO722> Subject: Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro Date: Fri, 29 Nov 2013 10:33:35 +0900 Message-id: <001d01ceeca3$0557d630$10078290$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7sAn2ARllmo5XuRi6GbbW1T+QMcQAnVVFg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsVy+t8zfd3376YHGezepmoxZ/0aNosPazUs ljRlWDQvXs9mcXnhJVaL2fcfs1hc3jWHzeLsvONsFmcW97I7cHrMauhl81iwqdTjxIzfLB77 565h9/iy6hqzR9+WVYwenzfJBbBHcdmkpOZklqUW6dslcGWcu6VTcF2uYuau10wNjMvEuxg5 OSQETCRmnOtjhLDFJC7cW8/WxcjFISSwjFHi/54DQAkOsKIJC4og4tMZJbYsWc0O4fxilNj9 7xQbSDebgJrEly+HwRIiAo2MEt2bZjKCOMwC1xglLsycyAzR0sYkse/iMiaQFk4BI4k5TVfB bGEBH4nF26eC2SwCqhLHu98zg9i8ArYSt389Z4KwBSV+TL7HAmIzC2hJrN95nAnClpfYvOYt M8St6hKP/uqChEWAxretWQ5VLiKx78U7sIMkBFo5JLqm9bJA7BKQ+Db5EAtEr6zEpgPMkLCQ lDi44gbLBEaJWUg2z0KyeRaSzbOQrFjAyLKKUTS1ILmgOCm9yFSvODG3uDQvXS85P3cTIyTG J+5gvH/A+hBjMtD6icxSosn5wBSRVxJvaGxmZGFqYmpsZG5pRpqwkjhv+qOkICGB9MSS1OzU 1ILUovii0pzU4kOMTBycUg2MWhdPVb3WbtFeqbo+VcT9/8H/MacPudnf0Dy15o/CmrKfrLfn i1Vmsrbu2T4tSPoS56xbm8K4/Z6cWNmgwlz0p5pN3azNNPzkO82U5mu7Fos+rlROnVS0SuKQ //WOhZc4Jov6z1GN2vc5TIvp3dEwn5rXh28G3JEz2Cr+/UHuudI4pjc/3BZeU2Ipzkg01GIu Kk4EAHI+xZgHAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIKsWRmVeSWpSXmKPExsVy+t9jQd3376YHGezer2AxZ/0aNosPazUs ljRlWDQvXs9mcXnhJVaL2fcfs1hc3jWHzeLsvONsFmcW97I7cHrMauhl81iwqdTjxIzfLB77 565h9/iy6hqzR9+WVYwenzfJBbBHNTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpa mCsp5CXmptoqufgE6Lpl5gAdpqRQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0k rGPMOHdLp+C6XMXMXa+ZGhiXiXcxcnBICJhITFhQ1MXICWSKSVy4t56ti5GLQ0hgOqPEliWr 2SGcX4wSu/+dYgOpYhNQk/jy5TBYQkSgkVGie9NMRhCHWeAao8SFmROZIVramCT2XVzGBNLC KWAkMafpKpgtLOAjsXj7VDCbRUBV4nj3e2YQm1fAVuL2r+dMELagxI/J91hAbGYBLYn1O48z QdjyEpvXvGWGuFtd4tFfXZCwCND4tjXLocpFJPa9eMc4gVFoFpJJs5BMmoVk0iwkLQsYWVYx iqYWJBcUJ6XnGuoVJ+YWl+al6yXn525iBCeQZ1I7GFc2WBxiFOBgVOLhXdE9PUiINbGsuDL3 EKMEB7OSCO+vIqAQb0piZVVqUX58UWlOavEhxmSgRycyS4km5wOTW15JvKGxiZmRpZGZhZGJ uTlpwkrivAdarQOFBNITS1KzU1MLUotgtjBxcEo1MJpqb7PkK3Q6LWCWXH+j/PK+R/63ajYf ifxfv/l/nIpMsdtRUYuo3I+JqYcydzSnP/zOd3Maj29ZgVudMH+FdM9qw5T5jyXPeHMfcxWK +rdWxMNT5Nt2NtGnX1meLPm9zm0ym3H9Ho43qwy7w76wVt3429df0/757Cv/aOb+RdcvCt96 6HC/WImlOCPRUIu5qDgRADt6YMZkAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, November 28, 2013 3:24 PM, Joe Perches wrote: >On Wed, 2013-11-27 at 21:53 -0800, 'Greg Kroah-Hartman' wrote: >>On Wed, Nov 27, 2013 at 09:40:13PM -0800, Joe Perches wrote: >>>On Thu, 2013-11-28 at 14:29 +0900, Jingoo Han wrote: >>>>On Thursday, November 28, 2013 1:08 PM, Greg Kroah-Hartman wrote: >>>>>On Thu, Nov 28, 2013 at 10:55:35AM +0900, Jingoo Han wrote: >>>>>> This macro is used to create a struct pci_device_id array. >>>>> >>>>> Yeah, and it's a horrid macro that deserves to be removed, please don't >>>>> use it in more places. >>>>> >>>>> Actually, if you could just remove it, that would be best, sorry, I'm >>>>> not going to take these patches. >>>> >>>> (+cc Joe Perches, Andrew Morton, Andy Whitcroft) >>>> >>>> Hi Joe Perches, >>>> >>>> Would you fix checkpatch.pl about DEFINE_PCI_DEVICE_TABLE? >>>> Currently, checkpatch.pl guides to use DEFINE_PCI_DEVICE_TABLE >>>> as below. >>>> >>>> WARNING: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id >>>> #331: FILE: drivers/usb/host/ehci-pci.c:331: >>>> +static const struct pci_device_id pci_ids [] = { { >>>> >>>> However, Greg Kroah-Hartman mentioned that DEFINE_PCI_DEVICE_TABLE >>>> shouldn't be used anymore. >>>> >>>> So, would you change checkpatch.pl in order to guide to use >>>> struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE? >>>> >>>> For example, >>>> WARNING: Use struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE >>> >>> The documentation doesn't agree with Greg. >[] >> I say just remove it, I should have done that years ago when I was the >> PCI maintainer, just never got around to it. No other bus has something >> like this for their device ids, why should PCI be "special"? > >Anyone else have an opinion? > >I don't care one way or another, but please, one way >not two. (+cc Bjorn Helgaas, linux-pci) Then, how about the following steps? 1. Fix ./Documentation/PCI/pci.txt as below. (Jingoo Han) The ID table is an array of struct pci_device_id entries ending with an -all-zero entry; use of the macro DEFINE_PCI_DEVICE_TABLE is the preferred -method of declaring the table. Each entry consists of: +all-zero entry; Each entry consists of: 2. Fix ./scripts/checkpatch.pl in order to guide to use struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE. (Joe Perches) 3. Replace DEFINE_PCI_DEVICE_TABLE of ./drivers/* with 'const struct pci_device_id'. (Jingoo Han) 4. These patches will be merged through 'driver-core.git' with 'Acked-by' of each subsystem maintainer. (Greg Kroah-Hartman) Best regards, Jingoo Han >Changing checkpatch is a trifle, but there are a _lot_ >of maintainers to work through if it's to be removed. > >It'll probably take several releases. > >$ git grep --name-only -w DEFINE_PCI_DEVICE_TABLE | \ > cut -f1,2 -d/ | uniq -c > 1 Documentation/PCI > 1 arch/x86 > 1 drivers/bcma > 3 drivers/block > 1 drivers/char > 1 drivers/cpufreq > 2 drivers/dma > 18 drivers/edac > 6 drivers/gpio > 6 drivers/gpu > 6 drivers/hwmon > 20 drivers/i2c > 2 drivers/infiniband > 1 drivers/ipack > 1 drivers/leds > 3 drivers/media > 10 drivers/mfd > 2 drivers/misc > 1 drivers/mmc > 1 drivers/mtd > 132 drivers/net > 1 drivers/ntb > 1 drivers/pci > 5 drivers/pcmcia > 2 drivers/platform > 1 drivers/ptp > 1 drivers/rapidio > 7 drivers/scsi > 3 drivers/spi > 65 drivers/staging > 3 drivers/tty > 1 drivers/uio > 5 drivers/usb > 1 drivers/video > 1 drivers/virtio > 3 drivers/vme > 9 drivers/watchdog > 1 drivers/xen > 1 include/linux > 1 scripts/checkpatch.pl > 1 scripts/tags.sh > 1 sound/oss > 67 sound/pci