From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755327AbdKGHcJ (ORCPT ); Tue, 7 Nov 2017 02:32:09 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:43690 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbdKGHcI (ORCPT ); Tue, 7 Nov 2017 02:32:08 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20171107073206epoutp039db21aba9bae44db2fcb48ae886674ef~0vVASh6xr3105931059epoutp03P X-AuditID: b6c32a47-cefff7000000102c-6a-5a016176a813 From: Fan Li To: "'Jaegeuk Kim'" Cc: "'Chao Yu'" , "'Chao Yu'" , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net In-reply-to: <20171107034034.GC92599@jaegeuk-macbookpro.roam.corp.google.com> Subject: RE: [f2fs-dev] [PATCH] f2fs: keep scanning until enough free nids are acquired Date: Tue, 07 Nov 2017 15:30:31 +0800 Message-id: <001d01d3579a$82f21680$88d64380$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset="Windows-1252" Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Content-language: en-us Thread-index: AQGnEzq66zygZAiwVMnNqXYl2eeWQQEVZItbAr9MKX2jQmYtwA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnleLIzCtJLcpLzFFi42LZdljTVLcskTHK4PVSHovTU88yWTxZP4vZ 4tIid4vLu+awWUx9vJbVgdWj5chbVo9NqzrZPHYv+Mzk8XmTXABLFJdNSmpOZllqkb5dAldG 3+lW1oJzvBXdb08xNjCu5upi5OSQEDCRmPZrM3MXIxeHkMAORom/nW8YIZzvjBIvNpxj6WLk AKtqXRkM0iAksJtRYuVtcYiaV4wSLz/OYQZJsAmoS2yZ2c0EYosIqEn07pvCBFLELNDOKPGr fw47SIJTwFdiR9tWNhBbWCBS4sCD06wgC1gEVCUO3S0DCfMKWEpcXtjPBmELSvyYfI8FxGYW MJB4/WsJO4QtL7F5zVtmiA8UJHacfc0IEReXmPTgITvEDU4Sf2f/YQO5QULgCJvE3K+djBAN LhKHGyAGSQgIS7w6vgXKlpZ4tmojVM06RonPZywgmrczSsz7+JEJImENtPkX1BV8Eh2H/7JD QohXoqNNCKLEQ+L0mVlQMx0lNr+YyAoJrQuMEl3vfrJPYJSfheS5WUiem4XkuVlIHlrAyLKK USy1oDg3PbXYqMBYrzgxt7g0L10vOT93EyM4mWi572Dcds7nEKMAB6MSD++MgwxRQqyJZcWV uYcYJTiYlUR4t6sDhXhTEiurUovy44tKc1KLDzFKc7AoifPWbbsWISSQnliSmp2aWpBaBJNl 4uCUamCceoDDu7DhydpJvE3hi87Le4n+2HJ7723JlNiIze+6zR3iVlbFrJLjMrhc+EbA2md7 sryO/M9j+308xPV9mkKcrhU8+8THeEzeM/uhTuFz/Ydnp3j0ll891DHrwpVX0ZFLpi04rR2s ejG64H0ETx5He0HwzUfME7/PteRSOWGz99XBJ0+fS7UpsRRnJBpqMRcVJwIA/4C2CyIDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t9jAd3SRMYog0mXjC1OTz3LZPFk/Sxm i0uL3C0u75rDZjH18VpWB1aPliNvWT02repk89i94DOTx+dNcgEsUVw2Kak5mWWpRfp2CVwZ fadbWQvO8VZ0vz3F2MC4mquLkYNDQsBEonVlcBcjF4eQwE5GiZk3TzNDOK8YJeZNOcfSxcjJ wSagLrFlZjcTiC0ioCbRu28KE0gRs0A7o8S7TQvYQRJCApcYJXacZwSxOQV8JXa0bWUDsYUF IiW2/vrCBLKNRUBV4tDdMpAwr4ClxOWF/WwQtqDEj8n3wHYxC+hJfPxzmxHClpfYvOYtM4gt IaAgsePsa6i4uMSkBw/ZIe5xkvg7+w/bBEbBWUhGzUIyahaSUbOQtC9gZFnFKJlaUJybnlts VGCUl1quV5yYW1yal66XnJ+7iREY/NsOa/XvYHy8JP4QowAHoxIP74yDDFFCrIllxZW5hxgl OJiVRHi3qwOFeFMSK6tSi/Lji0pzUosPMUpzsCiJ8/LnH4sUEkhPLEnNTk0tSC2CyTJxcEo1 MO7pWFO2+nvYWvubLc0F1/1S/rE52KV7OeYVHnlh8vtjUkTkUd2dzOJZ8xTDK+9/n3MrYJL5 UX5HmboNT1f7OIu0ap/QXRewpniNk+S1YyGJd6NvJcyN4LvCnHrDcOvXc/OXLWC8eSj0aOb5 d5s4b8fa5girallX7kyZeMn8neOcszkf+KVaapRYijMSDbWYi4oTAdMBepZ6AgAA X-CMS-MailID: 20171107073205epcas2p4c0a52f87eb40db44b0e44240abfae03e X-Msg-Generator: CA CMS-TYPE: 102P X-CMS-RootMailID: 20171107030535epcas1p2094e05ca25eecd2140518cab7a39723d X-RootMTR: 20171107030535epcas1p2094e05ca25eecd2140518cab7a39723d References: <001901d35775$47b598f0$d720cad0$@samsung.com> <20171107034034.GC92599@jaegeuk-macbookpro.roam.corp.google.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Tuesday, November 07, 2017 11:41 AM > To: Fan Li > Cc: 'Chao Yu'; 'Chao Yu'; linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH] f2fs: keep scanning until enough free nids are acquired > > Hi, > > I merged this patch after fixing some broken format. Could you please check your email configuration? > > Thanks, > Sorry to bother you with so trivial problem, mail configuration is fine, but I use a wrong way to copy the text this time, won't happen again. > On 11/07, Fan Li wrote: > > In current version, after scan_free_nid_bits, the scan is over if nid_cnt[FREE_NID] != 0. > > In most cases, there are still free nids in the free list during the > > scan, and scan_free_nid_bits usually can't increase nid_cnt[FREE_NID]. > > It causes that __build_free_nids is called many times without solving > > the shortage of the free nids. This patch fixes that. > > > > Signed-off-by: Fan li > > --- > > fs/f2fs/node.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 3d0d1be..5cef118 > > 100644 > > --- a/fs/f2fs/node.c > > +++ b/fs/f2fs/node.c > > @@ -2010,7 +2010,7 @@ static void __build_free_nids(struct f2fs_sb_info *sbi, bool sync, bool mount) > > /* try to find free nids in free_nid_bitmap */ > > scan_free_nid_bits(sbi); > > > > - if (nm_i->nid_cnt[FREE_NID]) > > + if (nm_i->nid_cnt[FREE_NID] >= NAT_ENTRY_PER_BLOCK) > > return; > > } > > > > -- > > 2.7.4