From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44203C3A59E for ; Tue, 3 Sep 2019 02:33:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2533E217D7 for ; Tue, 3 Sep 2019 02:33:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726994AbfICCdg convert rfc822-to-8bit (ORCPT ); Mon, 2 Sep 2019 22:33:36 -0400 Received: from emcscan.emc.com.tw ([192.72.220.5]:35595 "EHLO emcscan.emc.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfICCdf (ORCPT ); Mon, 2 Sep 2019 22:33:35 -0400 X-IronPort-AV: E=Sophos;i="5.56,253,1539619200"; d="scan'208";a="32010530" Received: from unknown (HELO webmail.emc.com.tw) ([192.168.10.1]) by emcscan.emc.com.tw with SMTP; 03 Sep 2019 10:33:34 +0800 Received: from 192.168.55.71 by webmail.emc.com.tw with Mail2000 ESMTPA Server V7.00(122352:0:AUTH_LOGIN) (envelope-from ); Tue, 03 Sep 2019 10:33:33 +0800 (CST) From: "Johnny.Chuang" To: "'Dmitry Torokhov'" Cc: , , =?big5?B?J1NUUkQyLb2ytGa8YCc=?= , =?big5?B?J1NUUkQyLbOvsVKp+rhnsnon?= , =?big5?B?J7Hns9W1vic=?= , "'jeff'" References: <1566958886-25756-1-git-send-email-johnny.chuang@emc.com.tw> <000601d55d49$05878160$10968420$@emc.com.tw> <20190829182933.GD187474@dtor-ws> In-Reply-To: <20190829182933.GD187474@dtor-ws> Subject: RE: [PATCH] Input: elants_i2c - return real value of elants_i2c_initialize() Date: Tue, 3 Sep 2019 10:33:33 +0800 Message-ID: <001e01d561ff$fb3d7000$f1b85000$@emc.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset="big5" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQFmeLP5IfQOHpOgOs9iM2bs2d5OHQE/UdUoAQf8D7yn5NEZcA== Content-Language: zh-tw x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcMDUwMTBcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy0zOGM2Yjg0MC1jZGYzLTExZTktODBkYy03YzVjZjg3NDk0NzhcYW1lLXRlc3RcMzhjNmI4NDItY2RmMy0xMWU5LTgwZGMtN2M1Y2Y4NzQ5NDc4Ym9keS50eHQiIHN6PSIxODA4IiB0PSIxMzIxMTk1MTYxMzU0MzUxODQiIGg9InkzM0pvY3p4U0UrSWVVMGRYdEIwWUU0aHhBND0iIGlkPSIiIGJsPSIwIiBibz0iMSIvPjwvbWV0YT4= x-dg-rorf: true Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, Thanks for your explanation. If I want to abandon this patch, what's step I need to do? Many thanks, Johnny -----Original Message----- From: 'Dmitry Torokhov' [mailto:dmitry.torokhov@gmail.com] Sent: Friday, August 30, 2019 2:30 AM To: Johnny.Chuang Cc: linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; STRD2-½²´f¼`; STRD2-³¯±R©ú¸g²z; '±ç³Õµ¾'; 'jeff' Subject: Re: [PATCH] Input: elants_i2c - return real value of elants_i2c_initialize() Hi Johnny, On Wed, Aug 28, 2019 at 10:33:46AM +0800, Johnny.Chuang wrote: > The return value of elants_i2c_initialize() was always 0. > It maybe register input device when initialize fail. We do not want to return error here, because it will abort probe, and then we will not be able to initiate firmware flash flow so we can attempt to recover the device. If you want to try you can change the ts->iap_mode before trying to register input device, but then you need to be very careful about registering and unregistering it later, after flashing or re-flashing firmware. > > Signed-off-by: Johnny Chuang > --- > drivers/input/touchscreen/elants_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/elants_i2c.c > b/drivers/input/touchscreen/elants_i2c.c > index d4ad24e..9c9816f 100644 > --- a/drivers/input/touchscreen/elants_i2c.c > +++ b/drivers/input/touchscreen/elants_i2c.c > @@ -571,7 +571,7 @@ static int elants_i2c_initialize(struct elants_data *ts) > if (error) > ts->iap_mode = ELAN_IAP_RECOVERY; > > - return 0; > + return error; > } > > /* > -- > 2.7.4 > Thanks. -- Dmitry