From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Arnd Bergmann'" <arnd@arndb.de>
Cc: <linux-kernel@vger.kernel.org>,
"'Linux FS-devel Mailing List'" <linux-fsdevel@vger.kernel.org>,
"'gregkh'" <gregkh@linuxfoundation.org>,
"'Valdis Kletnieks'" <valdis.kletnieks@vt.edu>,
"'Christoph Hellwig'" <hch@lst.de>, <sj1557.seo@samsung.com>,
<linkinjeon@gmail.com>
Subject: RE: [PATCH v8 02/13] exfat: add super block operations
Date: Fri, 10 Jan 2020 08:36:41 +0900 [thread overview]
Message-ID: <002001d5c745$a57b4dd0$f071e970$@samsung.com> (raw)
In-Reply-To: <CAK8P3a1wcrKzhhODwoQTu=WHorkd+dQThk+G9w77QSgJ=LnR4A@mail.gmail.com>
> > +static int exfat_fill_super(struct super_block *sb, struct fs_context
> > +*fc) {
> > + struct exfat_sb_info *sbi = sb->s_fs_info;
> > + struct exfat_mount_options *opts = &sbi->options;
> > + struct inode *root_inode;
> > + int err;
> > +
> > + if (opts->allow_utime == (unsigned short)-1)
> > + opts->allow_utime = ~opts->fs_dmask & 0022;
> > +
> > + if (opts->utf8 && strcmp(opts->iocharset,
> exfat_iocharset_with_utf8)) {
> > + exfat_msg(sb, KERN_WARNING,
> > + "utf8 enabled, \"iocharset=%s\" is recommended",
> > + exfat_iocharset_with_utf8);
> > + }
> > +
> > + if (opts->discard) {
> > + struct request_queue *q = bdev_get_queue(sb->s_bdev);
> > +
> > + if (!blk_queue_discard(q))
> > + exfat_msg(sb, KERN_WARNING,
> > + "mounting with \"discard\" option, but the
> device does not support discard");
> > + opts->discard = 0;
> > + }
> > +
> > + sb->s_flags |= SB_NODIRATIME;
> > + sb->s_magic = EXFAT_SUPER_MAGIC;
> > + sb->s_op = &exfat_sops;
>
> I don't see you set up s_time_gran, s_time_min and s_time_max anywhere.
> Please fill those to get the correct behavior. That also lets you drop the
> manual truncation of the values.
Okay!
Thanks!
>
> Arnd
next prev parent reply other threads:[~2020-01-09 23:36 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191220062731epcas1p475b8da9288b08c87e474a0c4e88ce219@epcas1p4.samsung.com>
2019-12-20 6:24 ` [PATCH v8 00/13] add the latest exfat driver Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 01/13] exfat: add in-memory and on-disk structures and headers Namjae Jeon
2019-12-29 14:11 ` Pali Rohár
2019-12-31 13:46 ` Namjae Jeon
2020-01-02 11:06 ` Pali Rohár
2020-01-02 11:11 ` Namjae Jeon
2019-12-31 13:25 ` Markus Elfring
2019-12-31 14:05 ` Markus Elfring
2019-12-20 6:24 ` [PATCH v8 02/13] exfat: add super block operations Namjae Jeon
2019-12-29 13:40 ` Pali Rohár
2020-01-02 6:06 ` Namjae Jeon
2020-01-02 8:30 ` Pali Rohár
2020-01-02 13:13 ` Namjae Jeon
2020-01-02 13:16 ` Pali Rohár
2020-01-02 13:41 ` Namjae Jeon
2020-01-02 14:13 ` Pali Rohár
2019-12-29 13:55 ` Pali Rohár
2019-12-31 13:32 ` Namjae Jeon
2020-01-08 19:55 ` Arnd Bergmann
2020-01-09 23:36 ` Namjae Jeon [this message]
2019-12-20 6:24 ` [PATCH v8 03/13] exfat: add inode operations Namjae Jeon
2019-12-29 14:15 ` Pali Rohár
2019-12-31 13:53 ` Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 04/13] exfat: add directory operations Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 05/13] exfat: add file operations Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 06/13] exfat: add exfat entry operations Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 07/13] exfat: add bitmap operations Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 08/13] exfat: add exfat cache Namjae Jeon
2019-12-29 14:23 ` Pali Rohár
2019-12-31 13:52 ` Namjae Jeon
2020-01-02 10:19 ` [v8 " Markus Elfring
2020-01-08 18:08 ` Pali Rohár
2020-01-08 18:46 ` Christoph Hellwig
2020-01-08 19:01 ` Pali Rohár
2019-12-20 6:24 ` [PATCH v8 09/13] exfat: add misc operations Namjae Jeon
2019-12-29 14:00 ` Pali Rohár
2019-12-31 13:34 ` Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 10/13] exfat: add nls operations Namjae Jeon
2019-12-31 14:23 ` Markus Elfring
2019-12-31 18:01 ` Joe Perches
2020-01-02 9:56 ` Markus Elfring
2019-12-20 6:24 ` [PATCH v8 11/13] exfat: add Kconfig and Makefile Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 12/13] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
2019-12-23 22:17 ` kbuild test robot
2019-12-20 6:24 ` [PATCH v8 13/13] MAINTAINERS: add exfat filesystem Namjae Jeon
2019-12-31 13:00 ` [PATCH v8 00/13] add the latest exfat driver Markus Elfring
2019-12-31 15:14 ` Matthew Wilcox
2019-12-31 23:56 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002001d5c745$a57b4dd0$f071e970$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox