From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754689AbbIHLsE (ORCPT ); Tue, 8 Sep 2015 07:48:04 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:42212 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754664AbbIHLsC (ORCPT ); Tue, 8 Sep 2015 07:48:02 -0400 X-AuditID: cbfee61a-f79a06d000005c6f-26-55eecaf0fb8a From: Chao Yu To: "'Nicholas Krause'" , jaegeuk@kernel.org Cc: cm224.lee@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <1441542526-11916-1-git-send-email-xerofoify@gmail.com> In-reply-to: <1441542526-11916-1-git-send-email-xerofoify@gmail.com> Subject: RE: [PATCH RESEND] f2fs:Fix incorrect return statement in the function f2fs_ioc_release_volatile_write Date: Tue, 08 Sep 2015 19:47:14 +0800 Message-id: <002201d0ea2c$37168df0$a543a9d0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQF+gFlAYY3EsYP6aMbn48wzrixfgJ7XVPjQ Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGLMWRmVeSWpSXmKPExsVy+t9jQd0Pp96FGmx4Lm1xbV8jk8WT9bOY LS4tcre4vGsOm8WvKbIOrB47Z91l99i0qpPNY/eCz0wefVtWMXp83iQXwBrFZZOSmpNZllqk b5fAlTHt0EzmggPsFZ9WdLA2MK5m62Lk5JAQMJG4vfkSlC0mceHeeiCbi0NIYBajxN6/59gh nFeMEhP/XWQHqWITUJFY3vGfqYuRg0NEwF7iVxc3SJhZIFHixod3TCC2kICzxJoJP8GGcgq4 SBz9uY4ZxBYWKJQ4uLadFcRmEVCVmLp1BlicV8BS4uibbnYIW1Dix+R7LBAztSTW7zzOBGHL S2xe85YZ4lAFiR1nXzOC2CICRhL/FryEqhGX2HjkFssERqFZSEbNQjJqFpJRs5C0LGBkWcUo kVqQXFCclJ5rmJdarlecmFtcmpeul5yfu4kRHBvPpHYwHtzlfohRgINRiYe3wetdqBBrYllx Ze4hRgkOZiUR3o1HgEK8KYmVValF+fFFpTmpxYcYpTlYlMR5ZVc+CxUSSE8sSc1OTS1ILYLJ MnFwSjUwLnywy7N401NfwaZTzjyvX+3KPd9nGHS1auLaBb88JiZGTcjW25wts5rr8M7YSXeW v3utXuidnrf+kc+B3QcqzCbK3Ez+0DMv4063+HqD7b/avp8Qnvr15pRl7ZU7f1q+ZmPdfSqE 93/yip4f76Oa7WYLpL9nMS34993v41Srq0+NDkXOfpLUnqXEUpyRaKjFXFScCABYU7F9iQIA AA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Nicholas Krause [mailto:xerofoify@gmail.com] > Sent: Sunday, September 06, 2015 8:29 PM > To: jaegeuk@kernel.org > Cc: cm224.lee@samsung.com; chao2.yu@samsung.com; linux-f2fs-devel@lists.sourceforge.net; > linux-kernel@vger.kernel.org > Subject: [PATCH RESEND] f2fs:Fix incorrect return statement in the function > f2fs_ioc_release_volatile_write > > This fixes the incorrect return statement at the end of the function > f2fs_ioc_release_volatile_write's body for returning zero as this is > incorrect due to the function call before this return statement to > the function punch_hole being able to fail and we should return this > function's return fail directly in order to signal to callers of the > function f2fs_ioc_release_volatile if a failure arises with this call > to punch_hole fails. > > Signed-off-by: Nicholas Krause Reviewed-by: Chao Yu