From: Jingoo Han <jg1.han@samsung.com>
To: "'Maxime Ripard'" <maxime.ripard@free-electrons.com>,
plagnioj@jcrosoft.com, tomi.valkeinen@ti.com
Cc: "'Alexandre Belloni'" <alexandre.belloni@free-electrons.com>,
hector.palacios@digi.com,
"'Thomas Petazzoni'" <thomas@free-electrons.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCHv2 3/3] fb: backlight: HX8357: Add HX8369 support
Date: Fri, 26 Jul 2013 08:52:09 +0900 [thread overview]
Message-ID: <002301ce8991$f9b82060$ed286120$@samsung.com> (raw)
In-Reply-To: <1374757513-2253-4-git-send-email-maxime.ripard@free-electrons.com>
On Thursday, July 25, 2013 10:05 PM, Maxime Ripard wrote:
>
> From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> Add support for the Himax HX8369 controller as it is quite similar to the
> hx8357.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Acked-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/hx8357.c | 221 ++++++++++++++++++++++++++++++++++++---
> 1 file changed, 206 insertions(+), 15 deletions(-)
>
[....]
> + ret = hx8357_spi_write_byte(lcdev, HX8357_SET_DISPLAY_ON);
> + if (ret < 0)
> + return ret;
> +
> + msleep(100);
Hi Maxime Ripard,
Could you add comment on this huge delay, too?
Best regards,
Jingoo Han
next prev parent reply other threads:[~2013-07-25 23:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 13:05 [PATCHv2 0/3] Few ignored framebuffer fixes/additions Maxime Ripard
2013-07-25 13:05 ` [PATCHv2 1/3] video: mxsfb: fix color settings for 18bit data bus and 32bpp Maxime Ripard
2013-07-25 13:05 ` [PATCHv2 2/3] video: hx8357: Make IM pins optional Maxime Ripard
2013-07-25 23:47 ` Jingoo Han
2013-07-25 13:05 ` [PATCHv2 3/3] fb: backlight: HX8357: Add HX8369 support Maxime Ripard
2013-07-25 23:52 ` Jingoo Han [this message]
2013-07-31 18:14 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002301ce8991$f9b82060$ed286120$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=hector.palacios@digi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=plagnioj@jcrosoft.com \
--cc=thomas@free-electrons.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox