public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "bumyong.lee" <bumyong.lee@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>,
	"'Vinod Koul'" <vkoul@kernel.org>,
	"'Philipp Zabel'" <p.zabel@pengutronix.de>
Cc: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] dmaengine: pl330: set subsys_initcall level
Date: Thu, 9 Nov 2023 13:34:46 +0900	[thread overview]
Message-ID: <002301da12c6$11465ee0$33d31ca0$@samsung.com> (raw)
In-Reply-To: <0db70a26-bc3f-48f4-acfc-9fc7f960252f@kernel.org>

> On 31/10/2023 04:48, Bumyong Lee wrote:
> > module_amba_driver is macro for module_init/exit module_init is
> > device_initcall level when it configured with built-in driver.
> >
> > pl330 is dmaengine driver. because slave drivers depend on dmaengine
> > drivers, dmaengine drivers is more appropriate subsys_initcall.
> 
> The same is true for all resource providers and we do not manually order
> them via initcalls. Sorry, this was fine as is. Implement defer for your
> drivers, not hack initcalls. If you upstreamed them, then it could even
> work out of the box for you .
> 
> Best regards,
> Krzysztof

I agree with your opinion that the drivers using dma-engine should implement to defer probe when dma is not initialized yet in their probe function execution.
But if dma-engine driver and slave driver is the same initcall level, then a lot of slave drivers should defer probe every time of boot.

I think it's better to use subsys_initcall for pl330 like other dmaengine drivers regardless of slave driver's implementation in order to reduce defer operations.

Best regards
Bumyong Lee


  reply	other threads:[~2023-11-09  4:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20231031035024epcas2p240760f064c90e017a3ada73d9271e9c9@epcas2p2.samsung.com>
2023-10-31  3:48 ` [PATCH] dmaengine: pl330: set subsys_initcall level Bumyong Lee
2023-11-07 10:03   ` Krzysztof Kozlowski
2023-11-09  4:34     ` bumyong.lee [this message]
2023-11-09  8:49       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002301da12c6$11465ee0$33d31ca0$@samsung.com' \
    --to=bumyong.lee@samsung.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox