From: Jingoo Han <jg1.han@samsung.com>
To: "'Heiko Stübner'" <heiko@sntech.de>
Cc: "'Bryan Wu'" <cooloney@gmail.com>,
"'Lee Jones'" <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH] backlight: extend of_find_backlight_by_node stub-check to modules
Date: Tue, 04 Nov 2014 10:08:08 +0900 [thread overview]
Message-ID: <002401cff7cb$cbee5650$63cb02f0$%han@samsung.com> (raw)
In-Reply-To: <16457372.FsSJIFmsla@diego>
On Tuesday, November 04, 2014 9:59 AM, Heiko Stübner wrote:
>
> Commit de3d75dc2311 ("backlight: Use of_find_backlight_by_node stub when
> backlight class disabled") did not take into account that the backlight
> class can also be compiled as module. Extend the check to prevent
> redefinition warnings when the backlight device class is compiled as module.
>
> Reported-by: kbuild test robot
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Jingoo Han <jg1.han@samsung.com>
If there is no objection, I hope that this patch is merged.
Thank you.
Best regards,
Jingoo Han
> ---
> include/linux/backlight.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> index d9cb644..92b9817 100644
> --- a/include/linux/backlight.h
> +++ b/include/linux/backlight.h
> @@ -157,7 +157,8 @@ struct generic_bl_info {
> void (*kick_battery)(void);
> };
>
> -#if defined(CONFIG_OF) && defined(CONFIG_BACKLIGHT_CLASS_DEVICE)
> +#if defined(CONFIG_OF) && (defined(CONFIG_BACKLIGHT_CLASS_DEVICE) || \
> + defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE))
> struct backlight_device *of_find_backlight_by_node(struct device_node *node);
> #else
> static inline struct backlight_device *
> --
> 2.0.1
next prev parent reply other threads:[~2014-11-04 1:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 0:59 [PATCH] backlight: extend of_find_backlight_by_node stub-check to modules Heiko Stübner
2014-11-04 1:08 ` Jingoo Han [this message]
2014-11-04 8:25 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002401cff7cb$cbee5650$63cb02f0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=cooloney@gmail.com \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox