From: Jingoo Han <jg1.han@samsung.com>
To: "'Andrew Morton'" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
"'Richard Purdie'" <rpurdie@rpsys.net>,
"'Milo Kim'" <milo.kim@ti.com>,
"'Daniel Jeong'" <gshark.jeong@gmail.com>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH 4/6] backlight: lm3639: Don't mix different enum types
Date: Thu, 05 Sep 2013 11:42:45 +0900 [thread overview]
Message-ID: <002501cea9e1$99d40db0$cd7c2910$%han@samsung.com> (raw)
In-Reply-To: <002101cea9e1$34a38330$9dea8990$%han@samsung.com>
Don't mix different enum types to fix the sparse warnings.
drivers/video/backlight/lm3639_bl.c:80:51: warning: mixing different enum types
drivers/video/backlight/lm3639_bl.c:80:51: int enum lm3639_fleds versus
drivers/video/backlight/lm3639_bl.c:80:51: int enum lm3639_bleds
drivers/video/backlight/lm3639_bl.c:82:51: warning: mixing different enum types
drivers/video/backlight/lm3639_bl.c:82:51: int enum lm3639_fleds versus
drivers/video/backlight/lm3639_bl.c:82:51: int enum lm3639_bleds
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/lm3639_bl.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
index 053964d..6c888e3 100644
--- a/drivers/video/backlight/lm3639_bl.c
+++ b/drivers/video/backlight/lm3639_bl.c
@@ -76,10 +76,13 @@ static int lm3639_chip_init(struct lm3639_chip_data *pchip)
goto out;
/* output pins config. */
- if (!pdata->init_brt_led)
- reg_val = pdata->fled_pins | pdata->bled_pins;
- else
- reg_val = pdata->fled_pins | pdata->bled_pins | 0x01;
+ if (!pdata->init_brt_led) {
+ reg_val = pdata->fled_pins;
+ reg_val |= pdata->bled_pins;
+ } else {
+ reg_val = pdata->fled_pins;
+ reg_val |= pdata->bled_pins | 0x01;
+ }
ret = regmap_update_bits(pchip->regmap, REG_ENABLE, 0x79, reg_val);
if (ret < 0)
--
1.7.10.4
next prev parent reply other threads:[~2013-09-05 2:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 2:39 [PATCH 0/6] backlight updates for 3.12-rc1 Jingoo Han
2013-09-05 2:41 ` [PATCH 1/6] backlight: lp855x_bl: support new LP8555 device Jingoo Han
2013-09-05 3:08 ` Sachin Kamat
2013-09-05 4:05 ` Jingoo Han
2013-09-05 2:41 ` [PATCH 2/6] backlight: lm3630: apply chip revision Jingoo Han
2013-09-05 2:42 ` [PATCH 3/6] backlight: ld9040: Staticize local variable gamma_table Jingoo Han
2013-09-05 2:42 ` Jingoo Han [this message]
2013-09-05 2:43 ` [PATCH 5/6] backlight: lp8788: Staticize 'default_bl_config' Jingoo Han
2013-09-05 2:44 ` [PATCH 6/6] backlight: use dev_get_platdata() Jingoo Han
2013-09-05 3:39 ` [PATCH 0/6] backlight updates for 3.12-rc1 Milo Kim
2013-09-05 3:52 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002501cea9e1$99d40db0$cd7c2910$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=gshark.jeong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox