From: "Manfred Spraul" <manfred@colorfullife.com>
To: "Francis Galiegue" <fg@mandrakesoft.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.4.9-ac10 but not only, locks_alloc_lock()
Date: Sun, 9 Sep 2001 11:25:15 +0200 [thread overview]
Message-ID: <002801c13911$59930880$010411ac@local> (raw)
> Not sure about one thing, though: what error code to return for
> locks_mandatory_area() on failure. It's invoked from some of the
> {do,sys}_*{read,write}*() routines and nowhere else AFAICT. I set it
to
> -ENOMEM, maybe this is not the right thing to do.
I'd put the file_lock structure on the stack. It's ~ 90 bytes long, not
too large.
Returning -ENOMEM is imho not acceptable: -ENOMEM is not listed in
SusV2, and locks_alloc_lock() internally checks for rlimits (setting
RLIM_NLIMITS to 0 and execing another app might have dangerous
sideeffects).
--
Manfred
next reply other threads:[~2001-09-09 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-09 9:25 Manfred Spraul [this message]
2001-09-09 10:33 ` [PATCH] 2.4.9-ac10 but not only, locks_alloc_lock() Francis Galiegue
-- strict thread matches above, loose matches on Subject: below --
2001-09-09 8:19 Francis Galiegue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002801c13911$59930880$010411ac@local' \
--to=manfred@colorfullife.com \
--cc=fg@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox