2.4 vm, program load, page faulting, ...

2.4 vm, program load, page faulting, ...

[Paul Albrecht]

... Why does the kernel page fault on text pages, present in the page cache,
when a program starts? Couldn't the pte's for text present in the page cache
be resolved when they're mapped to memory?

Re: 2.4 vm, program load, page faulting, ...

[Rik van Riel]

On Sat, 15 Mar 2003, Paul Albrecht wrote:

> ... Why does the kernel page fault on text pages, present in the page
> cache, when a program starts? Couldn't the pte's for text present in the
> page cache be resolved when they're mapped to memory?

The mmap() syscall only sets up the VMA info, it doesn't
fill in the page tables. That only happens when the process
page faults.

Note that filling in a bunch of page table entries mapping
already present pagecache pages at exec() time might be a
good idea.  It's just that nobody has gotten around to that
yet...

Re: 2.4 vm, program load, page faulting, ...

[William Lee Irwin III]

On Sat, 15 Mar 2003, Paul Albrecht wrote:
>> ... Why does the kernel page fault on text pages, present in the page
>> cache, when a program starts? Couldn't the pte's for text present in the
>> page cache be resolved when they're mapped to memory?

On Mon, Mar 17, 2003 at 10:02:21AM -0500, Rik van Riel wrote:
> The mmap() syscall only sets up the VMA info, it doesn't
> fill in the page tables. That only happens when the process
> page faults.
> Note that filling in a bunch of page table entries mapping
> already present pagecache pages at exec() time might be a
> good idea.  It's just that nobody has gotten around to that
> yet...

SVR4 did and saw an improvement wrt. page fault rate, according to
Vahalia.

I'd like to see whether this is useful for Linux.


-- wli

Re: 2.4 vm, program load, page faulting, ...

[Rik van Riel]

On Mon, 17 Mar 2003, William Lee Irwin III wrote:
> On Sat, 15 Mar 2003, Paul Albrecht wrote:
> >> ... Why does the kernel page fault on text pages, present in the page
> >> cache, when a program starts? Couldn't the pte's for text present in the
> >> page cache be resolved when they're mapped to memory?
> 
> SVR4 did and saw an improvement wrt. page fault rate, according to
> Vahalia.

An improvement in the _page fault rate_, well DUH.

> I'd like to see whether this is useful for Linux.

The question is, does it result in an improvement in the
run speed of processes...

cheers,

Rik

Re: 2.4 vm, program load, page faulting, ...

[wind]

On Mon, Mar 17, 2003 at 11:01:31AM -0500, Rik van Riel wrote:
> On Mon, 17 Mar 2003, William Lee Irwin III wrote:
> > On Sat, 15 Mar 2003, Paul Albrecht wrote:
> > >> ... Why does the kernel page fault on text pages, present in the page
> > >> cache, when a program starts? Couldn't the pte's for text present in the
> > >> page cache be resolved when they're mapped to memory?
> > 
> > SVR4 did and saw an improvement wrt. page fault rate, according to
> > Vahalia.
> 
> An improvement in the _page fault rate_, well DUH.
> 
> > I'd like to see whether this is useful for Linux.
> 
> The question is, does it result in an improvement in the
> run speed of processes...
> 
> cheers,
> 
> Rik

You should ask Andrew about his patch to do exactly that: he
forced all PROC_EXEC mmaps to be nonlinear-mapped and this
forced all programs to suck entire binaries into memory...
I recall he saw at least 25% improvement at launching gnome.

Andrew?

-- 
Antonio Vargas

Re: 2.4 vm, program load, page faulting, ...

[Alex Tomas]

>>>>> wind  (w) writes:

 w> On Mon, Mar 17, 2003 at 11:01:31AM -0500, Rik van Riel wrote:
 >> On Mon, 17 Mar 2003, William Lee Irwin III wrote:
 >> > On Sat, 15 Mar 2003, Paul Albrecht wrote:
 >> > >> ... Why does the kernel page fault on text pages, present in
 >> the page > >> cache, when a program starts? Couldn't the pte's for
 >> text present in the > >> page cache be resolved when they're
 >> mapped to memory?
 >> > 

 w> You should ask Andrew about his patch to do exactly that: he
 w> forced all PROC_EXEC mmaps to be nonlinear-mapped and this forced
 w> all programs to suck entire binaries into memory...  I recall he
 w> saw at least 25% improvement at launching gnome.

they talked about pages _already present_ in pagecache.

Re: 2.4 vm, program load, page faulting, ...

[wind-lkml]

On Mon, Mar 17, 2003 at 07:50:04PM +0300, Alex Tomas wrote:
> >>>>> wind  (w) writes:
> 
>  w> On Mon, Mar 17, 2003 at 11:01:31AM -0500, Rik van Riel wrote:
>  >> On Mon, 17 Mar 2003, William Lee Irwin III wrote:
>  >> > On Sat, 15 Mar 2003, Paul Albrecht wrote:
>  >> > >> ... Why does the kernel page fault on text pages, present in
>  >> the page > >> cache, when a program starts? Couldn't the pte's for
>  >> text present in the > >> page cache be resolved when they're
>  >> mapped to memory?
>  >> > 
> 
>  w> You should ask Andrew about his patch to do exactly that: he
>  w> forced all PROC_EXEC mmaps to be nonlinear-mapped and this forced
>  w> all programs to suck entire binaries into memory...  I recall he
>  w> saw at least 25% improvement at launching gnome.
> 
> they talked about pages _already present_ in pagecache.

I wonder if this could be done by walking and faulting
all pages at fs/binfmt_elf.c::elf_map just after do_mmap...
will try it just now :)

Re: 2.4 vm, program load, page faulting, ...

[wind-lkml]

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

On Mon, Mar 17, 2003 at 06:12:46PM +0100, wind-lkml@cocodriloo.com wrote:
> On Mon, Mar 17, 2003 at 07:50:04PM +0300, Alex Tomas wrote:
> > >>>>> wind  (w) writes:
> > 
> >  w> On Mon, Mar 17, 2003 at 11:01:31AM -0500, Rik van Riel wrote:
> >  >> On Mon, 17 Mar 2003, William Lee Irwin III wrote:
> >  >> > On Sat, 15 Mar 2003, Paul Albrecht wrote:
> >  >> > >> ... Why does the kernel page fault on text pages, present in
> >  >> the page > >> cache, when a program starts? Couldn't the pte's for
> >  >> text present in the > >> page cache be resolved when they're
> >  >> mapped to memory?
> >  >> > 
> > 
> >  w> You should ask Andrew about his patch to do exactly that: he
> >  w> forced all PROC_EXEC mmaps to be nonlinear-mapped and this forced
> >  w> all programs to suck entire binaries into memory...  I recall he
> >  w> saw at least 25% improvement at launching gnome.
> > 
> > they talked about pages _already present_ in pagecache.
> 
> I wonder if this could be done by walking and faulting
> all pages at fs/binfmt_elf.c::elf_map just after do_mmap...
> will try it just now :)

OK, this is not tested, since I'm compiling it now... feel free
to correct :)


[-- Attachment #2: binfmt_elf.c.diff --]
[-- Type: text/plain, Size: 878 bytes --]

--- orig/fs/binfmt_elf.c	Mon Mar 17 18:26:59 2003
+++ work/fs/binfmt_elf.c	Mon Mar 17 18:26:31 2003
@@ -259,12 +259,23 @@ create_elf_tables(struct linux_binprm *b
 static inline unsigned long
 elf_map (struct file *filep, unsigned long addr, struct elf_phdr *eppnt, int prot, int type)
 {
-	unsigned long map_addr;
+	unsigned long map_addr, pgoff;
+	struct mm *mm;
 
 	down_write(&current->mm->mmap_sem);
 	map_addr = do_mmap(filep, ELF_PAGESTART(addr),
 			   eppnt->p_filesz + ELF_PAGEOFFSET(eppnt->p_vaddr), prot, type,
 			   eppnt->p_offset - ELF_PAGEOFFSET(eppnt->p_vaddr));
+
+	/* preload elf image  */
+
+	mm = current->mm;
+	addr = ELF_PAGESTART(addr);
+	for(pgoff = 0; pgoff < eppnt->p_filesz;){
+		do_mmap_pgoff(mm, filep, addr, PAGE_SIZE, prot, type, pgoff);
+		addr += PAGE_SIZE;
+		pgoff += PAGE_SIZE;
+	}
 
 	up_write(&current->mm->mmap_sem);
 	return(map_addr);

Re: 2.4 vm, program load, page faulting, ...

[Marc-Christian Petersen]

On Monday 17 March 2003 18:38, wind-lkml@cocodriloo.com wrote:

Hi Wind,

> > I wonder if this could be done by walking and faulting
> > all pages at fs/binfmt_elf.c::elf_map just after do_mmap...
> > will try it just now :)
>
> OK, this is not tested, since I'm compiling it now... feel free
> to correct :)

mm/mmap.c:

unsigned long do_mmap_pgoff(struct file * file, unsigned long addr, unsigned 
long len,
        unsigned long prot, unsigned long flags, unsigned long pgoff)
{

your "do_mmap_pgoff" calls 7 arguments. Obviously it cannot compile 8-)

ciao, Marc

Re: 2.4 vm, program load, page faulting, ...

[wind-lkml]

On Mon, Mar 17, 2003 at 07:57:49PM +0100, Marc-Christian Petersen wrote:
> On Monday 17 March 2003 18:38, wind-lkml@cocodriloo.com wrote:
> 
> Hi Wind,
> 
> > > I wonder if this could be done by walking and faulting
> > > all pages at fs/binfmt_elf.c::elf_map just after do_mmap...
> > > will try it just now :)
> >
> > OK, this is not tested, since I'm compiling it now... feel free
> > to correct :)
> 
> mm/mmap.c:
> 
> unsigned long do_mmap_pgoff(struct file * file, unsigned long addr, unsigned 
> long len,
>         unsigned long prot, unsigned long flags, unsigned long pgoff)
> {
> 
> your "do_mmap_pgoff" calls 7 arguments. Obviously it cannot compile 8-)
> 

My first patch, I'm just becoming intimate with printk ;)

Re: 2.4 vm, program load, page faulting, ...

[wind]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

On Mon, Mar 17, 2003 at 08:06:36PM +0100, wind-lkml@cocodriloo.com wrote:
> On Mon, Mar 17, 2003 at 07:57:49PM +0100, Marc-Christian Petersen wrote:
> > On Monday 17 March 2003 18:38, wind-lkml@cocodriloo.com wrote:
> > 
> > Hi Wind,
> > 
> > > > I wonder if this could be done by walking and faulting
> > > > all pages at fs/binfmt_elf.c::elf_map just after do_mmap...
> > > > will try it just now :)
> > >
> > > OK, this is not tested, since I'm compiling it now... feel free
> > > to correct :)
> > 
> > mm/mmap.c:
> > 
> > unsigned long do_mmap_pgoff(struct file * file, unsigned long addr, unsigned 
> > long len,
> >         unsigned long prot, unsigned long flags, unsigned long pgoff)
> > {
> > 
> > your "do_mmap_pgoff" calls 7 arguments. Obviously it cannot compile 8-)
> > 
> 
> My first patch, I'm just becoming intimate with printk ;)

OK, so I took a different approach, and just called handle_mm_fault just
like if there had been user-level accesses to the file.

Applied on 2.5.63-uml1 and booted debian woody with it.

Can any of you try it on a real machine? (I dont have a test machine :(

Greets, Antonio.


[-- Attachment #2: prefault.patch --]
[-- Type: text/plain, Size: 879 bytes --]

--- orig/fs/binfmt_elf.c	Mon Mar 17 20:30:17 2003
+++ work/fs/binfmt_elf.c	Mon Mar 17 20:30:29 2003
@@ -259,12 +259,26 @@ create_elf_tables(struct linux_binprm *b
 static inline unsigned long
 elf_map (struct file *filep, unsigned long addr, struct elf_phdr *eppnt, int prot, int type)
 {
-	unsigned long map_addr;
+	struct mm_struct *mm;
+	struct vm_area_struct *vma;
+	unsigned long map_addr, n;
 
 	down_write(&current->mm->mmap_sem);
 	map_addr = do_mmap(filep, ELF_PAGESTART(addr),
 			   eppnt->p_filesz + ELF_PAGEOFFSET(eppnt->p_vaddr), prot, type,
 			   eppnt->p_offset - ELF_PAGEOFFSET(eppnt->p_vaddr));
+
+
+	addr = ELF_PAGESTART(addr);
+	mm = current->mm;
+	vma = find_vma(mm, addr);
+	if(!vma)
+		goto out;
+
+	for(n = 0; n < eppnt->p_filesz; n+=PAGE_SIZE)
+		handle_mm_fault(mm, vma, addr + n, 0);
+
+out:
 	up_write(&current->mm->mmap_sem);
 	return(map_addr);
 }

Re: 2.4 vm, program load, page faulting, ...

[Andrew Morton]

Alex Tomas <bzzz@tmi.comex.ru> wrote:
>
>  w> You should ask Andrew about his patch to do exactly that: he
>  w> forced all PROC_EXEC mmaps to be nonlinear-mapped and this forced
>  w> all programs to suck entire binaries into memory...  I recall he
>  w> saw at least 25% improvement at launching gnome.
> 
> they talked about pages _already present_ in pagecache.

2.5.64-mm8 does that too.  At mmap-time it will, for a PROT_EXEC mapping,
pull every affected page off disk and it will instantiate pte's against
them all via install_page().

So there should be zero major and minor faults against that mmap region
during application startup.

The improved IO layout appears to halve startup time for big things.  I
haven't attempted to instrument the effects of the reduced minor fault rate. 
If indeed the rate _has_ decreased.  If it hasn't, it's a bug...



This is all a bit dubious for several reasons.  Most particularly, the
up-front instantiation of the pages in pagetables makes unneeded pages harder
to reclaim.  It would be really neat if someone could try putting the
madvise(MADV_WILLNEED) into glibc and test that.  Maybe on a 2.4 kernel.

Re: 2.4 vm, program load, page faulting, ...

[wind]

[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]

On Mon, Mar 17, 2003 at 02:05:06PM -0800, Andrew Morton wrote:
> Alex Tomas <bzzz@tmi.comex.ru> wrote:
> >
> >  w> You should ask Andrew about his patch to do exactly that: he
> >  w> forced all PROC_EXEC mmaps to be nonlinear-mapped and this forced
> >  w> all programs to suck entire binaries into memory...  I recall he
> >  w> saw at least 25% improvement at launching gnome.
> > 
> > they talked about pages _already present_ in pagecache.
> 
> 2.5.64-mm8 does that too.  At mmap-time it will, for a PROT_EXEC mapping,
> pull every affected page off disk and it will instantiate pte's against
> them all via install_page().
> 
> So there should be zero major and minor faults against that mmap region
> during application startup.
> 
> The improved IO layout appears to halve startup time for big things.  I
> haven't attempted to instrument the effects of the reduced minor fault rate. 
> If indeed the rate _has_ decreased.  If it hasn't, it's a bug...
> 
> 
> 
> This is all a bit dubious for several reasons.  Most particularly, the
> up-front instantiation of the pages in pagetables makes unneeded pages harder
> to reclaim.  It would be really neat if someone could try putting the
> madvise(MADV_WILLNEED) into glibc and test that.  Maybe on a 2.4 kernel.


something like this one?


[-- Attachment #2: prefault-madvise.patch --]
[-- Type: text/plain, Size: 722 bytes --]

--- base/fs/binfmt_elf.c	Mon Mar 17 23:44:55 2003
+++ work/fs/binfmt_elf.c	Tue Mar 18 00:03:34 2003
@@ -256,6 +256,8 @@ create_elf_tables(struct linux_binprm *b
 
 #ifndef elf_map
 
+asmlinkage long sys_madvise(unsigned long start, size_t len, int behavior);
+
 static inline unsigned long
 elf_map (struct file *filep, unsigned long addr, struct elf_phdr *eppnt, int prot, int type)
 {
@@ -266,6 +268,10 @@ elf_map (struct file *filep, unsigned lo
 			   eppnt->p_filesz + ELF_PAGEOFFSET(eppnt->p_vaddr), prot, type,
 			   eppnt->p_offset - ELF_PAGEOFFSET(eppnt->p_vaddr));
 	up_write(&current->mm->mmap_sem);
+
+	if(prot & PROT_EXEC)
+		sys_madvise(map_addr, eppnt->p_filesz, MADV_WILLNEED);
+
 	return(map_addr);
 }
 

Re: 2.4 vm, program load, page faulting, ...

[Andrew Morton]

wind@cocodriloo.com wrote:
>
> > This is all a bit dubious for several reasons.  Most particularly, the
> > up-front instantiation of the pages in pagetables makes unneeded pages harder
> > to reclaim.  It would be really neat if someone could try putting the
> > madvise(MADV_WILLNEED) into glibc and test that.  Maybe on a 2.4 kernel.
> 
> 
> something like this one?
> 

No, not at all.  I meant a patch against glibc, not against the kernel!

Like this:

	map = mmap(..., PROT_EXEC, ...);
+	if (getenv("MAP_PREFAULT"))
+		madvise(map, length, MADV_WILLNEED);

Re: 2.4 vm, program load, page faulting, ...

[wind]

On Mon, Mar 17, 2003 at 03:28:55PM -0800, Andrew Morton wrote:
> wind@cocodriloo.com wrote:
> >
> > > This is all a bit dubious for several reasons.  Most particularly, the
> > > up-front instantiation of the pages in pagetables makes unneeded pages harder
> > > to reclaim.  It would be really neat if someone could try putting the
> > > madvise(MADV_WILLNEED) into glibc and test that.  Maybe on a 2.4 kernel.
> > 
> > 
> > something like this one?
> > 
> 
> No, not at all.  I meant a patch against glibc, not against the kernel!
> 
> Like this:
> 
> 	map = mmap(..., PROT_EXEC, ...);
> +	if (getenv("MAP_PREFAULT"))
> +		madvise(map, length, MADV_WILLNEED);


I know what you mean, but right now it's far easier hacking the
kernel than libc, at least if running a uml-kernel ;)

Anyways, I booted my patch but I don't know if it's working, because
I've got no test machine to try it on... but, it didn't freak out
so I think it works :)))

As for the libc patch, I think it can be easier to make an
exec-prefault.so library and LD_PRELOAD it, at least for testing
purposes.

If you could tell me the locking is right, I might try patching my
physical machine 2.4.19-ck4 with the kernel patch just to see if it
works.

Re: 2.4 vm, program load, page faulting, ...

[Alex Tomas]

>>>>> William Lee Irwin (WLI) writes:

 WLI> On Mon, Mar 17, 2003 at 10:02:21AM -0500, Rik van Riel wrote:
 >> The mmap() syscall only sets up the VMA info, it doesn't fill in
 >> the page tables. That only happens when the process page faults.
 >> Note that filling in a bunch of page table entries mapping already
 >> present pagecache pages at exec() time might be a good idea.  It's
 >> just that nobody has gotten around to that yet...

 WLI> SVR4 did and saw an improvement wrt. page fault rate, according
 WLI> to Vahalia.

 WLI> I'd like to see whether this is useful for Linux.

I tried this on dual P3 year and half ago and didn't see any improvement

Re: 2.4 vm, program load, page faulting, ...

[Paul Albrecht]

On Monday, March 17, 2003 Rik van Riel wrote:

>
> The mmap() syscall only sets up the VMA info, it doesn't fill in the page
tables. That only happens when the process page faults.
>
> Note that filling in a bunch of page table entries mapping already present
pagecache pages at exec() time might be a good idea.  It's just that nobody
has gotten around to that yet...
>

What doesn't make sense to me is that a program's working set isn't loaded
before it starts execution.  Can the working set be approximated using the
address_space object?  Then the kernel would know what pages should be
allocated when the text and data segments are memory mapped in binary load.