From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Vyacheslav Dubeyko'" <slava@dubeyko.com>
Cc: <gregkh@linuxfoundation.org>, <valdis.kletnieks@vt.edu>,
<hch@lst.de>, <sj1557.seo@samsung.com>,
<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: RE: [PATCH v6 05/13] exfat: add file operations
Date: Wed, 11 Dec 2019 10:00:50 +0900 [thread overview]
Message-ID: <002a01d5afbe$6e64e250$4b2ea6f0$@samsung.com> (raw)
In-Reply-To: <e234c599ec452ed81fb703c69adf60c1e57062dd.camel@dubeyko.com>
> > + /* Of the r and x bits, all (subject to umask) must be
> > present.*/
> > + if ((perm & 0555) != (i_mode & 0555))
I modified it due to warnning alarm from checkpatch.pl.
Other octal permissions are same reason.
WARNING: Symbolic permissions 'S_IRUGO | S_IXUGO' are not preferred. Consider using octal permissions '0555'.
+ if ((perm & (S_IRUGO | S_IXUGO)) != (i_mode & (S_IRUGO | S_IXUGO)))
> > + /* update the directory entry */
> > + if (!evict) {
> > + es = exfat_get_dentry_set(sb, &(ei->dir), ei->entry,
> > + ES_ALL_ENTRIES, &ep);
> > + if (!es)
> > + return -EIO;
> > + ep2 = ep + 1;
>
> The ep2 could point out on the garbage here. Maybe, it makes sense to
> add some check here?
Could you please elaborate more? How could ep2 be the garbage?
I want you to check exfat_get_dentry_set().
Thanks for your review!
next prev parent reply other threads:[~2019-12-11 1:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191209065457epcas1p3130d80fd65c9a1c1af5f67dadc49e913@epcas1p3.samsung.com>
2019-12-09 6:51 ` [PATCH v6 00/13] add the latest exfat driver Namjae Jeon
2019-12-09 6:51 ` [PATCH v6 01/13] exfat: add in-memory and on-disk structures and headers Namjae Jeon
2019-12-09 6:51 ` [PATCH v6 02/13] exfat: add super block operations Namjae Jeon
2019-12-09 9:24 ` Vyacheslav Dubeyko
2019-12-11 5:18 ` Namjae Jeon
2019-12-09 6:51 ` [PATCH v6 03/13] exfat: add inode operations Namjae Jeon
2019-12-09 9:54 ` Vyacheslav Dubeyko
2019-12-11 5:22 ` Namjae Jeon
2019-12-09 6:51 ` [PATCH v6 04/13] exfat: add directory operations Namjae Jeon
2019-12-09 11:05 ` Vyacheslav Dubeyko
2019-12-09 6:51 ` [PATCH v6 05/13] exfat: add file operations Namjae Jeon
2019-12-09 11:32 ` Vyacheslav Dubeyko
2019-12-11 1:00 ` Namjae Jeon [this message]
2019-12-09 6:51 ` [PATCH v6 06/13] exfat: add exfat entry operations Namjae Jeon
2019-12-09 11:41 ` Vyacheslav Dubeyko
2019-12-09 6:51 ` [PATCH v6 07/13] exfat: add bitmap operations Namjae Jeon
2019-12-09 12:07 ` Vyacheslav Dubeyko
2019-12-09 6:51 ` [PATCH v6 08/13] exfat: add exfat cache Namjae Jeon
2019-12-09 6:51 ` [PATCH v6 09/13] exfat: add misc operations Namjae Jeon
2019-12-09 6:51 ` [PATCH v6 10/13] exfat: add nls operations Namjae Jeon
2019-12-09 6:51 ` [PATCH v6 11/13] exfat: add Kconfig and Makefile Namjae Jeon
2019-12-09 6:51 ` [PATCH v6 12/13] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
2019-12-09 6:51 ` [PATCH v6 13/13] MAINTAINERS: add exfat filesystem Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002a01d5afbe$6e64e250$4b2ea6f0$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=slava@dubeyko.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox