* [PATCH V3] rtc: rtc-pcf2123: replace strict_strtoul() with kstrtoul()
@ 2013-06-04 4:12 Jingoo Han
2013-06-06 19:51 ` 'Greg Kroah-Hartman'
0 siblings, 1 reply; 4+ messages in thread
From: Jingoo Han @ 2013-06-04 4:12 UTC (permalink / raw)
To: 'Greg Kroah-Hartman'
Cc: linux-kernel, Arnd Bergmann, 'Jingoo Han',
Michael Hennerich, 'Eric Piel',
'Dimitri Sivanich', 'Robin Holt',
'Andy Shevchenko'
The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Changes since v1:
- Splitted to two sequential checks.
- Added Andy Shevchenko's Reviewed-by.
Changes since v1:
- Used return code from kstrtoul().
drivers/rtc/rtc-pcf2123.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c
index b2a78a0..1725b50 100644
--- a/drivers/rtc/rtc-pcf2123.c
+++ b/drivers/rtc/rtc-pcf2123.c
@@ -94,8 +94,9 @@ static ssize_t pcf2123_show(struct device *dev, struct device_attribute *attr,
r = container_of(attr, struct pcf2123_sysfs_reg, attr);
- if (strict_strtoul(r->name, 16, ®))
- return -EINVAL;
+ ret = kstrtoul(r->name, 16, ®);
+ if (ret)
+ return ret;
txbuf[0] = PCF2123_READ | reg;
ret = spi_write_then_read(spi, txbuf, 1, rxbuf, 1);
@@ -117,9 +118,13 @@ static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr,
r = container_of(attr, struct pcf2123_sysfs_reg, attr);
- if (strict_strtoul(r->name, 16, ®)
- || strict_strtoul(buffer, 10, &val))
- return -EINVAL;
+ ret = kstrtoul(r->name, 16, ®);
+ if (ret)
+ return ret;
+
+ ret = kstrtoul(buffer, 10, &val);
+ if (ret)
+ return ret;
txbuf[0] = PCF2123_WRITE | reg;
txbuf[1] = val;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V3] rtc: rtc-pcf2123: replace strict_strtoul() with kstrtoul()
2013-06-04 4:12 [PATCH V3] rtc: rtc-pcf2123: replace strict_strtoul() with kstrtoul() Jingoo Han
@ 2013-06-06 19:51 ` 'Greg Kroah-Hartman'
2013-06-07 0:57 ` Jingoo Han
0 siblings, 1 reply; 4+ messages in thread
From: 'Greg Kroah-Hartman' @ 2013-06-06 19:51 UTC (permalink / raw)
To: Jingoo Han
Cc: linux-kernel, Arnd Bergmann, Michael Hennerich,
'Eric Piel', 'Dimitri Sivanich',
'Robin Holt', 'Andy Shevchenko'
On Tue, Jun 04, 2013 at 01:12:52PM +0900, Jingoo Han wrote:
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> Changes since v1:
> - Splitted to two sequential checks.
> - Added Andy Shevchenko's Reviewed-by.
>
> Changes since v1:
> - Used return code from kstrtoul().
>
> drivers/rtc/rtc-pcf2123.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
I'm not the drivers/rtc/ maintainer, why send this to me?
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V3] rtc: rtc-pcf2123: replace strict_strtoul() with kstrtoul()
2013-06-06 19:51 ` 'Greg Kroah-Hartman'
@ 2013-06-07 0:57 ` Jingoo Han
0 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-06-07 0:57 UTC (permalink / raw)
To: 'Greg Kroah-Hartman'
Cc: linux-kernel, 'Arnd Bergmann',
'Michael Hennerich', 'Eric Piel',
'Dimitri Sivanich', 'Robin Holt',
'Andy Shevchenko', Jingoo Han
On Friday, June 07, 2013 4:52 AM, Greg Kroah-Hartman wrote:
> On Tue, Jun 04, 2013 at 01:12:52PM +0900, Jingoo Han wrote:
> > The usage of strict_strtoul() is not preferred, because
> > strict_strtoul() is obsolete. Thus, kstrtoul() should be
> > used.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > Changes since v1:
> > - Splitted to two sequential checks.
> > - Added Andy Shevchenko's Reviewed-by.
> >
> > Changes since v1:
> > - Used return code from kstrtoul().
> >
> > drivers/rtc/rtc-pcf2123.c | 15 ++++++++++-----
> > 1 file changed, 10 insertions(+), 5 deletions(-)
>
> I'm not the drivers/rtc/ maintainer, why send this to me?
Hi Greg,
Sorry. It's my mistake.
I will re-send it to the maintainer of rtc.
Thank you.
Best regards,
Jingoo Han
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH V3] rtc: rtc-pcf2123: replace strict_strtoul() with kstrtoul()
@ 2013-06-07 1:00 Jingoo Han
0 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-06-07 1:00 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Alessandro Zummo', rtc-linux,
'Jingoo Han', 'Andy Shevchenko'
The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Changes since v2:
- Split to two sequential checks.
- Added Andy Shevchenko's Reviewed-by.
Changes since v1:
- Used return code from kstrtoul().
drivers/rtc/rtc-pcf2123.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c
index b2a78a0..1725b50 100644
--- a/drivers/rtc/rtc-pcf2123.c
+++ b/drivers/rtc/rtc-pcf2123.c
@@ -94,8 +94,9 @@ static ssize_t pcf2123_show(struct device *dev, struct device_attribute *attr,
r = container_of(attr, struct pcf2123_sysfs_reg, attr);
- if (strict_strtoul(r->name, 16, ®))
- return -EINVAL;
+ ret = kstrtoul(r->name, 16, ®);
+ if (ret)
+ return ret;
txbuf[0] = PCF2123_READ | reg;
ret = spi_write_then_read(spi, txbuf, 1, rxbuf, 1);
@@ -117,9 +118,13 @@ static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr,
r = container_of(attr, struct pcf2123_sysfs_reg, attr);
- if (strict_strtoul(r->name, 16, ®)
- || strict_strtoul(buffer, 10, &val))
- return -EINVAL;
+ ret = kstrtoul(r->name, 16, ®);
+ if (ret)
+ return ret;
+
+ ret = kstrtoul(buffer, 10, &val);
+ if (ret)
+ return ret;
txbuf[0] = PCF2123_WRITE | reg;
txbuf[1] = val;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-07 1:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-04 4:12 [PATCH V3] rtc: rtc-pcf2123: replace strict_strtoul() with kstrtoul() Jingoo Han
2013-06-06 19:51 ` 'Greg Kroah-Hartman'
2013-06-07 0:57 ` Jingoo Han
-- strict thread matches above, loose matches on Subject: below --
2013-06-07 1:00 Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox