From: Jingoo Han <jg1.han@samsung.com>
To: "'Sachin Kamat'" <sachin.kamat@linaro.org>
Cc: "'Mark Brown'" <broonie@kernel.org>,
"'Liam Girdwood'" <lgirdwood@gmail.com>,
"'LKML'" <linux-kernel@vger.kernel.org>,
"'Steve Twiss'" <stwiss.opensource@diasemi.com>,
"'David Dajun Chen'" <david.chen@diasemi.com>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH V2 05/18] regulator: fixed: use devm_regulator_register()
Date: Thu, 26 Sep 2013 15:25:59 +0900 [thread overview]
Message-ID: <002b01ceba81$4413aa10$cc3afe30$%han@samsung.com> (raw)
In-Reply-To: <CAK9yfHxSFZv-=cdsoLzYBBZhShX9iMgoBBfOCJDLA3_P_dGetg@mail.gmail.com>
On Thursday, September 26, 2013 3:14 PM, Sachin Kamat wrote:
> On 26 September 2013 07:35, Jingoo Han <jg1.han@samsung.com> wrote:
> > Use devm_regulator_register() to make cleanup paths simpler.
>
> > struct fixed_voltage_data *drvdata = platform_get_drvdata(pdev);
> >
> > - regulator_unregister(drvdata->dev);
> > kfree(drvdata->desc.supply_name);
> > kfree(drvdata->desc.name);
>
> Sorry, couldn't go through all your patches yesterday.
> This one looks a bit scary too as some of the driver data is already
> freed before unregistering.
>
I looked at regulator_unregister(). I am not sure that this is safe.
So, I will remove this patch from next v3 patch series.
Thank you for your comment. :-)
Best regards,
Jingoo Han
next prev parent reply other threads:[~2013-09-26 6:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 2:02 [PATCH V2 01/18] regulator: ab3100: use devm_regulator_register() Jingoo Han
2013-09-26 2:03 ` [PATCH V2 02/18] regulator: ab8500-ext: " Jingoo Han
2013-09-26 2:04 ` [PATCH V2 03/18] regulator: da9063: " Jingoo Han
2013-09-26 2:04 ` [PATCH V2 04/18] regulator: da9210: " Jingoo Han
2013-09-26 2:05 ` [PATCH V2 05/18] regulator: fixed: " Jingoo Han
2013-09-26 6:14 ` Sachin Kamat
2013-09-26 6:25 ` Jingoo Han [this message]
2013-09-26 10:16 ` Mark Brown
2013-09-26 2:06 ` [PATCH V2 06/18] regulator: gpio-regulator: " Jingoo Han
2013-09-26 6:20 ` Sachin Kamat
2013-09-26 6:30 ` Jingoo Han
2013-09-26 2:07 ` [PATCH V2 07/18] regulator: lp3971: " Jingoo Han
2013-09-26 6:36 ` Jingoo Han
2013-09-26 2:08 ` [PATCH V2 08/18] regulator: lp872x: " Jingoo Han
2013-09-26 2:08 ` [PATCH V2 09/18] regulator: lp8788-buck: " Jingoo Han
2013-09-26 2:09 ` [PATCH V2 10/18] regulator: lp8788-ldo: " Jingoo Han
2013-09-26 2:09 ` [PATCH V2 11/18] regulator: max8925: " Jingoo Han
2013-09-26 2:10 ` [PATCH V2 12/18] regulator: max8952: " Jingoo Han
2013-09-26 6:41 ` Jingoo Han
2013-09-26 2:10 ` [PATCH V2 13/18] regulator: pcap: " Jingoo Han
2013-09-26 2:11 ` [PATCH V2 14/18] regulator: pcf50633: " Jingoo Han
2013-09-26 2:11 ` [PATCH V2 15/18] regulator: tps6105x: " Jingoo Han
2013-09-26 2:12 ` [PATCH V2 16/18] regulator: tps6524x: " Jingoo Han
2013-09-26 2:13 ` [PATCH V2 17/18] regulator: twl: " Jingoo Han
2013-09-26 7:11 ` Jingoo Han
2013-09-26 2:13 ` [PATCH V2 18/18] regulator: vexpress: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002b01ceba81$4413aa10$cc3afe30$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=broonie@kernel.org \
--cc=david.chen@diasemi.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox