From: Florian Fainelli <f.fainelli@gmail.com>
To: Gerhard Wiesinger <lists@wiesinger.com>,
arm@lists.fedoraproject.org, Chen-Yu Tsai <wens@csie.org>,
LKML <linux-kernel@vger.kernel.org>,
filbar@centrum.cz
Subject: Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA
Date: Sun, 21 Jun 2020 14:10:16 -0700 [thread overview]
Message-ID: <002b144c-3e71-4418-3a6b-ee17c2ce6b38@gmail.com> (raw)
In-Reply-To: <6495b781-03a1-c655-90b2-71fe984ef02f@wiesinger.com>
Le 2020-06-20 à 12:37, Gerhard Wiesinger a écrit :
> Hello Florian,
>
> On 20.06.2020 21:13, Florian Fainelli wrote:
>> Hi,
>>
>> On 6/20/2020 10:39 AM, Gerhard Wiesinger wrote:
>> Can you share your network configuration again with me?
>
> Find the network config below.
>
>
>>> # OK: Last good known version (booting that version is also ok)
>>> Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020
>>> armv7l armv7l armv7l GNU/Linux
>> OK, I suspect what has changed is this commit:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8fab459e69abfd04a66d76423d18ba853fced4ab
>>
>>
>> which, if I remember your configuration correctly means that you now
>> have proper DSA interfaces and so all of the wan, lan1-lan4 interfaces
>> can now run a proper networking stack unlike before where you had to do
>> this via the DSA master network device (eth0). This also means that you
>> should run your DHCP server/client on the bridge master network device
>> now.
>
> Yes, config should be a proper DSA config, see also below. IP config is
> only on brlan and brwan.
>
> Do the changes need a config change?
> e.g. net: dsa: b53: Ensure the default VID is untagged
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/dsa/b53?id=d965a5432d4c3e6b9c3d2bc1d4a800013bbf76f6
>
No that change does not require a configuration change, the one I
mentioned does, you should only have a single bridge for all LAN ports
and no bridge for the WAN port and no VLAN is necessary since now that
Broadcom tags are enabled, Linux can properly determine which source and
destination port should be used.
Please try that and let me know how it goes.
--
Florian
next prev parent reply other threads:[~2020-06-21 21:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 17:39 Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA Gerhard Wiesinger
2020-06-20 19:13 ` Florian Fainelli
2020-06-20 19:37 ` Gerhard Wiesinger
2020-06-21 21:10 ` Florian Fainelli [this message]
2020-06-25 23:23 ` [fedora-arm] " Peter Robinson
2020-06-26 4:41 ` Florian Fainelli
2020-06-26 9:09 ` Peter Robinson
2020-06-26 15:46 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=002b144c-3e71-4418-3a6b-ee17c2ce6b38@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arm@lists.fedoraproject.org \
--cc=filbar@centrum.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@wiesinger.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox