From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Pali Rohár'" <pali.rohar@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <valdis.kletnieks@vt.edu>,
<hch@lst.de>, <sj1557.seo@samsung.com>, <linkinjeon@gmail.com>,
<arnd@arndb.de>
Subject: RE: [PATCH v10 11/14] exfat: add Kconfig and Makefile
Date: Fri, 17 Jan 2020 13:22:27 +0900 [thread overview]
Message-ID: <002f01d5cced$ba0828b0$2e187a10$@samsung.com> (raw)
In-Reply-To: <20200115093915.cjef2jadiwe2eul4@pali>
> > +config EXFAT_DEFAULT_IOCHARSET
> > + string "Default iocharset for exFAT"
> > + default "utf8"
> > + depends on EXFAT_FS
> > + help
> > + Set this to the default input/output character set you'd
> > + like exFAT to use. It should probably match the character set
> > + that most of your exFAT filesystems use, and can be overridden
> > + with the "iocharset" mount option for exFAT filesystems.
>
> Hello! This description is incorrect. iocharset option specify what
> character set is expected by VFS layer and not character set used by exFAT
> filesystem. exFAT filesystem always uses UTF-16 as this is the only
> allowed by exFAT specification.
Hi Pali,
Could you please review updated description ?
diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
index 9eeaa6d06..f2b0cf2c1 100644
--- a/fs/exfat/Kconfig
+++ b/fs/exfat/Kconfig
@@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET
default "utf8"
depends on EXFAT_FS
help
- Set this to the default input/output character set you'd
- like exFAT to use. It should probably match the character set
- that most of your exFAT filesystems use, and can be overridden
- with the "iocharset" mount option for exFAT filesystems.
+ Set this to the default input/output character set to use for
+ converting between the encoding is used for user visible filename and
+ UTF-16 character that exfat filesystem use. and can be overridden with
+ the "iocharset" mount option for exFAT filesystems.
next prev parent reply other threads:[~2020-01-17 4:22 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200115082818epcas1p4892a99345626188afd111ee263132458@epcas1p4.samsung.com>
2020-01-15 8:24 ` [PATCH v10 00/14] add the latest exfat driver Namjae Jeon
2020-01-15 8:24 ` [PATCH v10 01/14] exfat: add in-memory and on-disk structures and headers Namjae Jeon
2020-01-15 8:24 ` [PATCH v10 02/14] exfat: add super block operations Namjae Jeon
2020-01-15 8:24 ` [PATCH v10 03/14] exfat: add inode operations Namjae Jeon
2020-01-15 10:25 ` Arnd Bergmann
2020-01-15 13:39 ` Namjae Jeon
2020-01-17 9:25 ` Pali Rohár
2020-01-17 11:17 ` Pali Rohár
2020-01-15 8:24 ` [PATCH v10 04/14] exfat: add directory operations Namjae Jeon
2020-01-17 11:13 ` Pali Rohár
2020-01-15 8:24 ` [PATCH v10 05/14] exfat: add file operations Namjae Jeon
2020-01-15 9:56 ` Arnd Bergmann
2020-01-15 13:07 ` Namjae Jeon
2020-01-17 9:18 ` Pali Rohár
2020-01-17 12:12 ` Namjae Jeon
2020-01-15 8:24 ` [PATCH v10 06/14] exfat: add fat entry operations Namjae Jeon
2020-01-15 8:24 ` [PATCH v10 07/14] exfat: add bitmap operations Namjae Jeon
2020-01-15 8:24 ` [PATCH v10 08/14] exfat: add exfat cache Namjae Jeon
2020-01-15 8:24 ` [PATCH v10 09/14] exfat: add misc operations Namjae Jeon
2020-01-15 10:10 ` Arnd Bergmann
2020-01-15 13:30 ` Namjae Jeon
2020-01-15 13:38 ` Pali Rohár
2020-01-15 13:50 ` Arnd Bergmann
2020-01-15 14:24 ` Pali Rohár
2020-01-15 15:03 ` Arnd Bergmann
2020-01-15 15:39 ` Pali Rohár
2020-01-15 15:52 ` Arnd Bergmann
2020-01-16 10:19 ` Pali Rohár
2020-01-16 10:23 ` Christoph Hellwig
2020-01-16 16:00 ` Pali Rohár
2020-01-17 2:59 ` Namjae Jeon
2020-01-17 10:13 ` Arnd Bergmann
2020-01-17 12:13 ` Namjae Jeon
2020-01-15 8:24 ` [PATCH v10 10/14] exfat: add nls operations Namjae Jeon
2020-01-15 8:24 ` [PATCH v10 11/14] exfat: add Kconfig and Makefile Namjae Jeon
2020-01-15 9:39 ` Pali Rohár
2020-01-17 4:22 ` Namjae Jeon [this message]
2020-01-17 9:12 ` Pali Rohár
2020-01-17 11:59 ` Namjae Jeon
2020-01-15 8:24 ` [PATCH v10 12/14] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
2020-01-15 8:24 ` [PATCH v10 13/14] MAINTAINERS: add exfat filesystem Namjae Jeon
2020-01-15 8:24 ` [PATCH v10 14/14] staging: exfat: make staging/exfat and fs/exfat mutually exclusive Namjae Jeon
2020-01-15 8:56 ` Greg KH
2020-01-15 13:06 ` Namjae Jeon
2020-01-15 9:47 ` [PATCH v10 00/14] add the latest exfat driver Pali Rohár
2020-01-15 13:05 ` Namjae Jeon
2020-01-16 10:51 ` Christoph Hellwig
2020-01-16 11:32 ` Pali Rohár
2020-01-16 13:01 ` Greg KH
2020-01-17 6:43 [PATCH v10 11/14] exfat: add Kconfig and Makefile Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002f01d5cced$ba0828b0$2e187a10$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sj1557.seo@samsung.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox