* [PATCH 34/42] rtc: rtc-spear: remove unnecessary platform_set_drvdata()
@ 2013-05-03 6:36 Jingoo Han
2013-05-04 6:15 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-03 6:36 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Alessandro Zummo', rtc-linux, Jingoo Han
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/rtc/rtc-spear.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
index 574359c..c492cf0 100644
--- a/drivers/rtc/rtc-spear.c
+++ b/drivers/rtc/rtc-spear.c
@@ -417,7 +417,6 @@ static int spear_rtc_probe(struct platform_device *pdev)
return 0;
err_disable_clock:
- platform_set_drvdata(pdev, NULL);
clk_disable_unprepare(config->clk);
return status;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 34/42] rtc: rtc-spear: remove unnecessary platform_set_drvdata()
2013-05-03 6:36 [PATCH 34/42] rtc: rtc-spear: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-04 6:15 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2013-05-04 6:15 UTC (permalink / raw)
To: Jingoo Han; +Cc: Andrew Morton, linux-kernel, Alessandro Zummo, rtc-linux
On Fri, May 3, 2013 at 12:06 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/rtc/rtc-spear.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
Thanks.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-04 6:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-03 6:36 [PATCH 34/42] rtc: rtc-spear: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-04 6:15 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox