* [PATCH 1/2] ARM: dts: add DP clock reference to exynos5250 device tree
@ 2013-05-11 7:42 Jingoo Han
2013-05-11 21:25 ` Doug Anderson
[not found] ` <CAGm_ybh_Uvs2dX3Ecgcwy=GFO6QH-Hj1jz3f1=cDbZGq0Q4qDQ@mail.gmail.com>
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-05-11 7:42 UTC (permalink / raw)
To: 'Kukjin Kim'
Cc: linux-samsung-soc, Jingoo Han, 'Thomas Abraham',
'Olof Johansson', 'Doug Anderson',
linux-arm-kernel, linux-kernel
The transition to common clock happened; however, DP (Display Port)
clock node was not added. Thus, DP (Display Port) clock node should
be added to the device tree.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Tested on Exynos5250
arch/arm/boot/dts/exynos5250.dtsi | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 9dfc6de..8b1f9b6 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -651,6 +651,8 @@
reg = <0x145b0000 0x1000>;
interrupts = <10 3>;
interrupt-parent = <&combiner>;
+ clocks = <&clock 342>;
+ clock-names = "dp";
#address-cells = <1>;
#size-cells = <0>;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] ARM: dts: add DP clock reference to exynos5250 device tree
2013-05-11 7:42 [PATCH 1/2] ARM: dts: add DP clock reference to exynos5250 device tree Jingoo Han
@ 2013-05-11 21:25 ` Doug Anderson
[not found] ` <CAGm_ybh_Uvs2dX3Ecgcwy=GFO6QH-Hj1jz3f1=cDbZGq0Q4qDQ@mail.gmail.com>
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2013-05-11 21:25 UTC (permalink / raw)
To: Jingoo Han
Cc: Kukjin Kim, linux-samsung-soc, Thomas Abraham, Olof Johansson,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Stéphane Marchesin, Sean Paul
Jingoo,
On Sat, May 11, 2013 at 12:42 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> The transition to common clock happened; however, DP (Display Port)
> clock node was not added. Thus, DP (Display Port) clock node should
> be added to the device tree.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> Tested on Exynos5250
>
> arch/arm/boot/dts/exynos5250.dtsi | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
Clock number matches clock bindings for 5250 and clock name matches dp
driver, so this looks good.
Reviewed-by: Doug Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <CAGm_ybh_Uvs2dX3Ecgcwy=GFO6QH-Hj1jz3f1=cDbZGq0Q4qDQ@mail.gmail.com>]
* RE: [PATCH 1/2] ARM: dts: add DP clock reference to exynos5250 device tree
[not found] ` <CAGm_ybh_Uvs2dX3Ecgcwy=GFO6QH-Hj1jz3f1=cDbZGq0Q4qDQ@mail.gmail.com>
@ 2013-06-05 11:25 ` Kukjin Kim
0 siblings, 0 replies; 3+ messages in thread
From: Kukjin Kim @ 2013-06-05 11:25 UTC (permalink / raw)
To: 'Vikas Sajjan', 'Jingoo Han'
Cc: linux-samsung-soc, 'Thomas Abraham',
'Olof Johansson', 'Doug Anderson',
linux-arm-kernel, linux-kernel, 'sunil joshi'
Vikas Sajjan wrote:
>
> Hi Mr. Jingoo Han,
>
> On Sat, May 11, 2013 at 1:12 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> The transition to common clock happened; however, DP (Display Port)
> clock node was not added. Thus, DP (Display Port) clock node should
> be added to the device tree.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> Tested on Exynos5250
>
> arch/arm/boot/dts/exynos5250.dtsi | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
[...]
> I have already sent similar patch on 8th May 2013.
>
> http://www.spinics.net/lists/linux-samsung-soc/msg18136.html
Vikas, please don't use html typed e-mail :-(
OK, I found Jingoo's ack on that.
Let me take that with Jingoo's ack and Doug's review tag.
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-05 11:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-11 7:42 [PATCH 1/2] ARM: dts: add DP clock reference to exynos5250 device tree Jingoo Han
2013-05-11 21:25 ` Doug Anderson
[not found] ` <CAGm_ybh_Uvs2dX3Ecgcwy=GFO6QH-Hj1jz3f1=cDbZGq0Q4qDQ@mail.gmail.com>
2013-06-05 11:25 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox