From: Jingoo Han <jg1.han@samsung.com>
To: "'Mark Brown'" <broonie@kernel.org>,
"'Sachin Kamat'" <sachin.kamat@linaro.org>
Cc: "'Liam Girdwood'" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, "'Balaji T K'" <balajitk@ti.com>,
"'Nishanth Menon'" <nm@ti.com>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH V2 17/18] regulator: twl: use devm_regulator_register()
Date: Thu, 26 Sep 2013 16:11:59 +0900 [thread overview]
Message-ID: <003001ceba87$b0fb17c0$12f14740$%han@samsung.com> (raw)
In-Reply-To: <001701ceba5d$f0827750$d18765f0$%han@samsung.com>
On Thursday, September 26, 2013 11:13 AM, Jingoo Han wrote:
>
> Use devm_regulator_register() to make cleanup paths simpler.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> Acked-by: Nishanth Menon <nm@ti.com>
> ---
> drivers/regulator/twl-regulator.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
[.....]
> @@ -1217,7 +1217,6 @@ static int twlreg_remove(struct platform_device *pdev)
> struct regulator_dev *rdev = platform_get_drvdata(pdev);
> struct twlreg_info *info = rdev->reg_data;
>
> - regulator_unregister(rdev);
> kfree(info);
> return 0;
> }
kfree(info) is kfree(rdev->reg_data).
The following would be right.
1. kfree(rdev->reg_data)
2. regulator_unregister(rdev)
Also, regulator_unregister() does not access 'rdev->reg_data'.
So, it would not make the problem.
Best regards,
Jingoo Han
next prev parent reply other threads:[~2013-09-26 7:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 2:02 [PATCH V2 01/18] regulator: ab3100: use devm_regulator_register() Jingoo Han
2013-09-26 2:03 ` [PATCH V2 02/18] regulator: ab8500-ext: " Jingoo Han
2013-09-26 2:04 ` [PATCH V2 03/18] regulator: da9063: " Jingoo Han
2013-09-26 2:04 ` [PATCH V2 04/18] regulator: da9210: " Jingoo Han
2013-09-26 2:05 ` [PATCH V2 05/18] regulator: fixed: " Jingoo Han
2013-09-26 6:14 ` Sachin Kamat
2013-09-26 6:25 ` Jingoo Han
2013-09-26 10:16 ` Mark Brown
2013-09-26 2:06 ` [PATCH V2 06/18] regulator: gpio-regulator: " Jingoo Han
2013-09-26 6:20 ` Sachin Kamat
2013-09-26 6:30 ` Jingoo Han
2013-09-26 2:07 ` [PATCH V2 07/18] regulator: lp3971: " Jingoo Han
2013-09-26 6:36 ` Jingoo Han
2013-09-26 2:08 ` [PATCH V2 08/18] regulator: lp872x: " Jingoo Han
2013-09-26 2:08 ` [PATCH V2 09/18] regulator: lp8788-buck: " Jingoo Han
2013-09-26 2:09 ` [PATCH V2 10/18] regulator: lp8788-ldo: " Jingoo Han
2013-09-26 2:09 ` [PATCH V2 11/18] regulator: max8925: " Jingoo Han
2013-09-26 2:10 ` [PATCH V2 12/18] regulator: max8952: " Jingoo Han
2013-09-26 6:41 ` Jingoo Han
2013-09-26 2:10 ` [PATCH V2 13/18] regulator: pcap: " Jingoo Han
2013-09-26 2:11 ` [PATCH V2 14/18] regulator: pcf50633: " Jingoo Han
2013-09-26 2:11 ` [PATCH V2 15/18] regulator: tps6105x: " Jingoo Han
2013-09-26 2:12 ` [PATCH V2 16/18] regulator: tps6524x: " Jingoo Han
2013-09-26 2:13 ` [PATCH V2 17/18] regulator: twl: " Jingoo Han
2013-09-26 7:11 ` Jingoo Han [this message]
2013-09-26 2:13 ` [PATCH V2 18/18] regulator: vexpress: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003001ceba87$b0fb17c0$12f14740$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=balajitk@ti.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox