From: "Tomoya MORINAGA" <tomoya-linux@dsn.okisemi.com>
To: "Marc Kleine-Budde" <mkl@pengutronix.de>
Cc: <andrew.chih.howe.khor@intel.com>,
"Masayuki Ohtake" <masa-korg@dsn.okisemi.com>,
"Samuel Ortiz" <sameo@linux.intel.com>, <margie.foster@intel.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<socketcan-core@lists.berlios.de>, <yong.y.wang@intel.com>,
<kok.howg.ewe@intel.com>,
"Wolfgang Grandegger" <wg@grandegger.com>, <joel.clark@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Christian Pellegrin" <chripell@fsfe.org>, <qi.wang@intel.com>
Subject: Re: [PATCH net-next-2.6 v3] can: Topcliff: PCH_CAN driver: Add Flow control,
Date: Mon, 22 Nov 2010 14:05:52 +0900 [thread overview]
Message-ID: <003201cb8a02$f05b15e0$66f8800a@maildom.okisemi.com> (raw)
In-Reply-To: 4CE64167.2030405@pengutronix.de
On Friday, November 19, 2010 6:20 PM, Marc Kleine-Budde wrote :
>>>> - spin_unlock_irqrestore(&priv->msgif_reg_lock, flags);
>>>> + pch_can_rw_msg_obj(&priv->regs->ifregs[1].creq, tx_obj_no);
>>> Still we have the busy waiting in the TX path. Maybe you can move the
>>> waiting before accessing the if[1] and remove the busy waiting here.
>> I can't understand your saying.
>> For transmitting data, calling pch_can_rw_msg_obj is mandatory.
>Yes, but the busy wait is not needed. It should be enough to do the
>busy-waiting _before_ accessing the if[1].
Do you mean we should create other pch_can_rw_msg_obj which doesn't have busy wait ?
---
Thanks,
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.
next prev parent reply other threads:[~2010-11-22 5:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 8:39 [PATCH net-next-2.6 v3] can: Topcliff: PCH_CAN driver: Add Flow control, Tomoya MORINAGA
2010-11-16 11:04 ` Wolfgang Grandegger
2010-11-16 12:22 ` Marc Kleine-Budde
2010-11-19 6:18 ` Tomoya MORINAGA
[not found] ` <4CE64167.2030405@pengutronix.de>
2010-11-22 5:05 ` Tomoya MORINAGA [this message]
2010-11-22 8:27 ` Marc Kleine-Budde
2010-11-24 0:09 ` Tomoya MORINAGA
2010-11-24 12:34 ` Marc Kleine-Budde
2010-11-25 12:03 ` Tomoya MORINAGA
2010-11-25 12:08 ` Marc Kleine-Budde
2010-11-25 12:34 ` Tomoya MORINAGA
2010-11-25 12:40 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003201cb8a02$f05b15e0$66f8800a@maildom.okisemi.com' \
--to=tomoya-linux@dsn.okisemi.com \
--cc=andrew.chih.howe.khor@intel.com \
--cc=chripell@fsfe.org \
--cc=davem@davemloft.net \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=wg@grandegger.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox