RE: [PATCH] Checks for Null return of skb_alloc in send_flowc

["Steve Wise" <swise@opengridcomputing.com>]

> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@gmail.com]
> Sent: Tuesday, June 17, 2014 10:25 AM
> To: swise@chelsio.com
> Cc: roland@kernel.org; sean.hefty@intel.com; hal.rosenstock@gmail.com; linux-
> rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] Checks for Null return of skb_alloc in send_flowc
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index 5e153f6..7e3d663 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -457,6 +457,10 @@ static void send_flowc(struct c4iw_ep *ep, struct sk_buff *skb)
>  	int i;
> 
>  	skb = get_skb(skb, flowclen, GFP_KERNEL);
> +	if (!skb) {
> +		kfree_skb(skb);
> +		pr_warn(MOD "%s failed to allocate skb.\n", __func__);
> +	}

You still don't have this right.  :( 

Like this:

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 5e153f6..3c55e88 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -457,6 +457,8 @@ static void send_flowc(struct c4iw_ep *ep, struct sk_buff *skb)
        int i;

        skb = get_skb(skb, flowclen, GFP_KERNEL);
+       if (!skb)
+               return;
        flowc = (struct fw_flowc_wr *)__skb_put(skb, flowclen);

        flowc->op_to_nparams = cpu_to_be32(FW_WR_OP(FW_FLOWC_WR) |