* [PATCH] Checks for Null return of skb_alloc in send_flowc
@ 2014-06-17 15:24 Nicholas Krause
2014-06-17 15:30 ` Steve Wise
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Krause @ 2014-06-17 15:24 UTC (permalink / raw)
To: swise; +Cc: roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/infiniband/hw/cxgb4/cm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 5e153f6..7e3d663 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -457,6 +457,10 @@ static void send_flowc(struct c4iw_ep *ep, struct sk_buff *skb)
int i;
skb = get_skb(skb, flowclen, GFP_KERNEL);
+ if (!skb) {
+ kfree_skb(skb);
+ pr_warn(MOD "%s failed to allocate skb.\n", __func__);
+ }
flowc = (struct fw_flowc_wr *)__skb_put(skb, flowclen);
flowc->op_to_nparams = cpu_to_be32(FW_WR_OP(FW_FLOWC_WR) |
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] Checks for Null return of skb_alloc in send_flowc
2014-06-17 15:24 [PATCH] Checks for Null return of skb_alloc in send_flowc Nicholas Krause
@ 2014-06-17 15:30 ` Steve Wise
0 siblings, 0 replies; 2+ messages in thread
From: Steve Wise @ 2014-06-17 15:30 UTC (permalink / raw)
To: 'Nicholas Krause', swise
Cc: roland, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel
> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@gmail.com]
> Sent: Tuesday, June 17, 2014 10:25 AM
> To: swise@chelsio.com
> Cc: roland@kernel.org; sean.hefty@intel.com; hal.rosenstock@gmail.com; linux-
> rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] Checks for Null return of skb_alloc in send_flowc
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index 5e153f6..7e3d663 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -457,6 +457,10 @@ static void send_flowc(struct c4iw_ep *ep, struct sk_buff *skb)
> int i;
>
> skb = get_skb(skb, flowclen, GFP_KERNEL);
> + if (!skb) {
> + kfree_skb(skb);
> + pr_warn(MOD "%s failed to allocate skb.\n", __func__);
> + }
You still don't have this right. :(
Like this:
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 5e153f6..3c55e88 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -457,6 +457,8 @@ static void send_flowc(struct c4iw_ep *ep, struct sk_buff *skb)
int i;
skb = get_skb(skb, flowclen, GFP_KERNEL);
+ if (!skb)
+ return;
flowc = (struct fw_flowc_wr *)__skb_put(skb, flowclen);
flowc->op_to_nparams = cpu_to_be32(FW_WR_OP(FW_FLOWC_WR) |
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-17 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-17 15:24 [PATCH] Checks for Null return of skb_alloc in send_flowc Nicholas Krause
2014-06-17 15:30 ` Steve Wise
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox