From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165AbbCXFC5 (ORCPT ); Tue, 24 Mar 2015 01:02:57 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:44398 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbbCXFCy (ORCPT ); Tue, 24 Mar 2015 01:02:54 -0400 X-AuditID: cbfee61a-f79c06d000004e71-bf-5510effccd05 From: Chao Yu To: "'Jaegeuk Kim'" Cc: "'Changman Lee'" , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <002201d06511$16e17c70$44a47550$@samsung.com> <20150324044211.GA35842@jaegeuk-mac02.hsd1.ca.comcast.net> In-reply-to: <20150324044211.GA35842@jaegeuk-mac02.hsd1.ca.comcast.net> Subject: RE: [PATCH 1/4] f2fs: limit b_size of mapped bh in f2fs_map_bh Date: Tue, 24 Mar 2015 13:02:04 +0800 Message-id: <003301d065ef$c78b03f0$56a10bd0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQKPyF1p6rHXU5sPCrNO9/L2ufNvowDDnBbjm6YxOdA= Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsVy+t9jQd0/7wVCDR5tFbO4tq+RyeLJ+lnM FpcWuVtc3jWHzYHFY9OqTjaP3Qs+M3n0bVnF6PF5k1wASxSXTUpqTmZZapG+XQJXxoTTn9gK pvBWvLt3ibmBcRFXFyMnh4SAicT0rk0sELaYxIV769m6GLk4hASmM0p8WfaZGcJ5xSjxcfdp dpAqNgEVieUd/5lAbBEBNYnefVOAbA4OZoEiiVUrBEDCQgJlEg9XrQMLcwq4S7w/ngUSFgYy px14DLaLRUBVYu+VvWA2r4ClxMyO9awQtqDEj8n3wOLMAloSm7c1sULY8hKb17xlhrhTQWLH 2deMEBdYSUxavpoRokZcYuORWywTGIVmIRk1C8moWUhGzULSsoCRZRWjaGpBckFxUnquoV5x Ym5xaV66XnJ+7iZGcAQ8k9rBuLLB4hCjAAejEg9vwBKBUCHWxLLiytxDjBIczEoivN6XgUK8 KYmVValF+fFFpTmpxYcYpTlYlMR5lezbQoQE0hNLUrNTUwtSi2CyTBycUg2MPR/akkwL9HO/ XJbbpWOU8Pi+Ed9syWurG7wZDAs/Hi7+85NdIfrMhUWTbm0RKltVOOPzB55bO1uLric8mfPH 2F57jaH18wMlhzgvie79+uAZ52ZjQXc33g3zjyuyFkRx7ZijY7/PpP3Cyfg3yquDnkiqS/tJ J/+2FXr8jaUktqE27PY7v4wIJZbijERDLeai4kQA6DvW6XwCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Tuesday, March 24, 2015 12:42 PM > To: Chao Yu > Cc: Changman Lee; linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/4] f2fs: limit b_size of mapped bh in f2fs_map_bh > > Hi Chao, > > On Mon, Mar 23, 2015 at 10:28:00AM +0800, Chao Yu wrote: > > Map bh over max size which caller defined is not needed, limit it in > > f2fs_map_bh. > > > > Signed-off-by: Chao Yu > > --- > > fs/f2fs/data.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > > index f0a18a0..a99bc7f 100644 > > --- a/fs/f2fs/data.c > > +++ b/fs/f2fs/data.c > > @@ -255,15 +255,16 @@ static void f2fs_map_bh(struct super_block *sb, pgoff_t pgofs, > > struct extent_info *ei, struct buffer_head *bh_result) > > { > > unsigned int blkbits = sb->s_blocksize_bits; > > + unsigned int maxblocks = bh_result->b_size >> blkbits; > > size_t count; > > > > clear_buffer_new(bh_result); > > map_bh(bh_result, sb, ei->blk + pgofs - ei->fofs); > > count = ei->fofs + ei->len - pgofs; > > - if (count < (UINT_MAX >> blkbits)) > > - bh_result->b_size = (count << blkbits); > > + if (count > maxblocks) > > + bh_result->b_size = maxblocks << blkbits; > > else > > - bh_result->b_size = UINT_MAX; > > + bh_result->b_size = count << blkbits; > > How about using min()? Better, I will do it. :) Thanks, > > Thanks, > > > } > > > > static bool lookup_extent_info(struct inode *inode, pgoff_t pgofs, > > -- > > 2.3.3