From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D21B24BBEB for ; Sun, 8 Feb 2026 13:05:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770555954; cv=none; b=GtfiVghOCDcunBa6YP3VK0r6ayk7wimKI8co3waOVJx3dAG3/5nv99jN0NhTe4xQObYRwtA++L/ACbsq/Ydwg9sCXvRnJMhBvgz6FZrW2KTunI9755FDyLE4Wb1dosyGLiJc23Uu1KG6XYss2gdFgOt3/fiySukyxRVSlix477A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770555954; c=relaxed/simple; bh=osT0EUva0gXZ1pK88EukUzwSiu7f4mThiV/KwigTGzQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LkseUiRZ2SapQ19qIFxgyZ1qL8r/0k2Zqp4YetK99+J1Y4l8M1aI0Xn5QDEn0ctSh9cxI21oB/u6E3zv6AzKZXC1hfGg9dg2ATwNKMmw3SC7VuRQAVzjAJlwSDEZ8mbFYgzR98uzzScVG04avAeO2pFDOngYNJZIj9Kz6njZIe8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J7EhQkTh; arc=none smtp.client-ip=209.85.128.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J7EhQkTh" Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-47f5c2283b6so34073385e9.1 for ; Sun, 08 Feb 2026 05:05:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770555953; x=1771160753; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S6ZaHSw9LpRz01vg6acbUDvWM+cc8+yuVQwbsTXMnoc=; b=J7EhQkThA2l+rof3AOzI/crRVbSKPsQ3H1oU5Cl77W8vHcmN64O4AW36/L0bBRuYao QA1NJCRLmSI7GzB51Sz1funRAp2CG3svzIxhcwGgnGFkx51hK+drRRm6aEagZYEZvBh8 FgoJFbogl6kj7vZ88/Qg+r2GfszxFt2Eh5YPT7L2rZbtll8h5oEOuJT2pWOQuBX5dniJ W+3ZgdEuSqtruad4O3g75HBhtOWYQFXCfUzp9oyaGfkpmpEyDhmgEvNNSulny1rj5vd3 xlLpRusLQNtvNGtiDwAr6zWXveOzhbRNtCmvfGKLeQugIS1CWKAk/6BdjmBR/a4ZFE4A TzTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770555953; x=1771160753; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S6ZaHSw9LpRz01vg6acbUDvWM+cc8+yuVQwbsTXMnoc=; b=CN3EDWUGgu6fM7epEUwJytNV1ChJfVpZhXfe0/6X4PwJwTty6bmC+zsKnwx+fj17Ic TekDiqSuen3GykgzN/mLf1NVIon4oQ/q8uv4dZmDnLRk89LerYSsWokjOgeMQgGMbpTk YHccissNdLOVDfT2RGBaSiRR2Sgo2H41qFxuL/+ZX0gYr/Ylhs08bLSfr00R4S62HMZM kTYsvEJ5uqfaPAvdThXbFvdeQkgUVez5rl9hj0MDY8e7V4bBjzRsmYpTcrvqTB21bDrp q9cqHv4ruMjudCD2d4D8q0rCc9YC/du7YyLyAQnyBNcBkUGTQ54/w4UlpvK9im2djVF+ inPg== X-Forwarded-Encrypted: i=1; AJvYcCUChxlIPj01ZHI6HqlXoUjQSwW/VySAkRz9MSE6RTWqjfr4zVB6IUWEfz97xMRWL/4SvOImr9H5b91C/mM=@vger.kernel.org X-Gm-Message-State: AOJu0YxX+mZpiAaDKyCyGhVEwbtd0VBAK2/pGSnWvjRarCVGZeFNrF8X wCuI3n7tcfQHCgd+r3flmReV/0bLOUl6fbK/oK4dS2rcjEh2uABtJfxM X-Gm-Gg: AZuq6aKokV/sFSdCFnH1QrFp+4wwcDHSMDcgq2iu0t+0gG/fSLUpc73RpqO84MeeUUc W4bLToRcshaEW5AxCrdj/h6Cvlr65j5Ai3UravpDYsBoZaIR3FS4J98+qeGeGkLDaz5Nb0JIIZx a97QJigEiXwAkEbyJa3yE6+yw2PmKZT4QECq+1Q9QH4sr6z43yama/hBhtbliB8Mo9Gsnbo8I1/ oUxLIyh4dYy4dtlRsABPRZYrlFtuv1wr+HUISeTAIUgI8WY9tYrUf/m7eYWtta5vAS4pCulAK6T Rr4OcYSor93IzMd5/V1I3FH4qRsDqZdVxx5PxkpNDfJ4pA9+AcllNkblUye6/23r8GrRg0PShW1 Tgdqt1PFHf4TsBICD+VYIjdqCGcBnFGSWDicIqSqAuNmIknA29NJvAGs8qbP5ry5Hi1lWSq0p0k 6DTncmYJ1Ka5MC54FHyjFkFh4= X-Received: by 2002:a05:600c:4f54:b0:47d:403e:9cd5 with SMTP id 5b1f17b1804b1-4832020df4emr103964445e9.11.1770555952781; Sun, 08 Feb 2026 05:05:52 -0800 (PST) Received: from [192.168.0.131] ([194.183.54.57]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436296b2110sm19201164f8f.3.2026.02.08.05.05.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Feb 2026 05:05:52 -0800 (PST) Message-ID: <0033b0b2-1eb3-4486-abe4-62d25f10b22c@gmail.com> Date: Sun, 8 Feb 2026 14:05:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/12] dt-bindings: leds: document Samsung S2M series PMIC RGB LED device To: Kaustabh Chakraborty , Rob Herring Cc: Lee Jones , Pavel Machek , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , Krzysztof Kozlowski , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Alexandre Belloni , Jonathan Corbet , Shuah Khan , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org References: <20260126-s2mu005-pmic-v2-0-78f1a75f547a@disroot.org> <20260126-s2mu005-pmic-v2-2-78f1a75f547a@disroot.org> <20260206133837.GA157817-robh@kernel.org> Content-Language: en-US From: Jacek Anaszewski In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Kaustabh, On 2/6/26 14:56, Kaustabh Chakraborty wrote: > On 2026-02-06 07:38 -06:00, Rob Herring wrote: >> On Mon, Jan 26, 2026 at 12:37:09AM +0530, Kaustabh Chakraborty wrote: >>> Certain Samsung S2M series PMICs have a three-channel LED device with >>> independent brightness control for each channel, typically used as >>> status indicators in mobile phones. Document the devicetree schema from >>> this device. >>> >>> Signed-off-by: Kaustabh Chakraborty >>> --- >>> .../bindings/leds/samsung,s2mu005-rgb.yaml | 34 ++++++++++++++++++++++ >>> 1 file changed, 34 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/leds/samsung,s2mu005-rgb.yaml b/Documentation/devicetree/bindings/leds/samsung,s2mu005-rgb.yaml >>> new file mode 100644 >>> index 0000000000000..6806b6d869ff7 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/leds/samsung,s2mu005-rgb.yaml >>> @@ -0,0 +1,34 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/leds/samsung,s2mu005-rgb.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: RGB LED Controller for Samsung S2M series PMICs >>> + >>> +maintainers: >>> + - Kaustabh Chakraborty >>> + >>> +description: | >>> + The Samsung S2M series PMIC RGB LED is a three-channel LED device with >>> + 8-bit brightness control for each channel, typically used as status >>> + indicators in mobile phones. >>> + >>> + This is a part of device tree bindings for S2M and S5M family of Power >>> + Management IC (PMIC). >>> + >>> + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for >>> + additional information and example. >>> + >>> +allOf: >>> + - $ref: common.yaml# >> >> This looks a bit lacking. Don't you need 3 child nodes for each or >> reference to the multi-color schema? > > rgb { > compatible = "samsung,s2mu005-rgb"; > label = "notification:rgb:indicator"; > color = ; > function = LED_FUNCTION_INDICATOR; > linux,default-trigger = "pattern"; > }; Having label together with color and function doesn't make sense. Please read label documentation in [0]. [0] Documentation/devicetree/bindings/leds/common.yaml -- Best regards, Jacek Anaszewski