* [PATCH 1/5] watchdog: cpwd: use platform_{get,set}_drvdata()
@ 2013-05-23 10:43 Jingoo Han
2013-05-24 14:58 ` Guenter Roeck
2013-05-26 13:29 ` Wim Van Sebroeck
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-05-23 10:43 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Wim Van Sebroeck', linux-watchdog,
'Guenter Roeck', 'Jingoo Han'
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/watchdog/cpwd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c
index 7038758..213225e 100644
--- a/drivers/watchdog/cpwd.c
+++ b/drivers/watchdog/cpwd.c
@@ -621,7 +621,7 @@ static int cpwd_probe(struct platform_device *op)
WD_BADMODEL);
}
- dev_set_drvdata(&op->dev, p);
+ platform_set_drvdata(op, p);
cpwd_device = p;
err = 0;
@@ -642,7 +642,7 @@ out_free:
static int cpwd_remove(struct platform_device *op)
{
- struct cpwd *p = dev_get_drvdata(&op->dev);
+ struct cpwd *p = platform_get_drvdata(op);
int i;
for (i = 0; i < WD_NUMDEVS; i++) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/5] watchdog: cpwd: use platform_{get,set}_drvdata()
2013-05-23 10:43 [PATCH 1/5] watchdog: cpwd: use platform_{get,set}_drvdata() Jingoo Han
@ 2013-05-24 14:58 ` Guenter Roeck
2013-05-26 13:29 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2013-05-24 14:58 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', linux-kernel, 'Wim Van Sebroeck',
linux-watchdog
On Thu, May 23, 2013 at 07:43:43PM +0900, Jingoo Han wrote:
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/cpwd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c
> index 7038758..213225e 100644
> --- a/drivers/watchdog/cpwd.c
> +++ b/drivers/watchdog/cpwd.c
> @@ -621,7 +621,7 @@ static int cpwd_probe(struct platform_device *op)
> WD_BADMODEL);
> }
>
> - dev_set_drvdata(&op->dev, p);
> + platform_set_drvdata(op, p);
> cpwd_device = p;
> err = 0;
>
> @@ -642,7 +642,7 @@ out_free:
>
> static int cpwd_remove(struct platform_device *op)
> {
> - struct cpwd *p = dev_get_drvdata(&op->dev);
> + struct cpwd *p = platform_get_drvdata(op);
> int i;
>
> for (i = 0; i < WD_NUMDEVS; i++) {
> --
> 1.7.10.4
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/5] watchdog: cpwd: use platform_{get,set}_drvdata()
2013-05-23 10:43 [PATCH 1/5] watchdog: cpwd: use platform_{get,set}_drvdata() Jingoo Han
2013-05-24 14:58 ` Guenter Roeck
@ 2013-05-26 13:29 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Wim Van Sebroeck @ 2013-05-26 13:29 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', linux-kernel, linux-watchdog,
'Guenter Roeck'
Hi Jingoo,
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/watchdog/cpwd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Patch added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-26 13:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-23 10:43 [PATCH 1/5] watchdog: cpwd: use platform_{get,set}_drvdata() Jingoo Han
2013-05-24 14:58 ` Guenter Roeck
2013-05-26 13:29 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox