* [PATCH 2/5] watchdog: da9052: use platform_{get,set}_drvdata()
@ 2013-05-23 10:44 Jingoo Han
2013-05-24 14:58 ` Guenter Roeck
2013-05-26 13:36 ` Wim Van Sebroeck
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-05-23 10:44 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Wim Van Sebroeck', linux-watchdog,
'Guenter Roeck', Jingoo Han
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/watchdog/da9052_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c
index 3674450..f09c54e 100644
--- a/drivers/watchdog/da9052_wdt.c
+++ b/drivers/watchdog/da9052_wdt.c
@@ -215,14 +215,14 @@ static int da9052_wdt_probe(struct platform_device *pdev)
goto err;
}
- dev_set_drvdata(&pdev->dev, driver_data);
+ platform_set_drvdata(pdev, driver_data);
err:
return ret;
}
static int da9052_wdt_remove(struct platform_device *pdev)
{
- struct da9052_wdt_data *driver_data = dev_get_drvdata(&pdev->dev);
+ struct da9052_wdt_data *driver_data = platform_get_drvdata(pdev);
watchdog_unregister_device(&driver_data->wdt);
kref_put(&driver_data->kref, da9052_wdt_release_resources);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/5] watchdog: da9052: use platform_{get,set}_drvdata()
2013-05-23 10:44 [PATCH 2/5] watchdog: da9052: use platform_{get,set}_drvdata() Jingoo Han
@ 2013-05-24 14:58 ` Guenter Roeck
2013-05-26 13:36 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2013-05-24 14:58 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', linux-kernel, 'Wim Van Sebroeck',
linux-watchdog
On Thu, May 23, 2013 at 07:44:09PM +0900, Jingoo Han wrote:
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/da9052_wdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c
> index 3674450..f09c54e 100644
> --- a/drivers/watchdog/da9052_wdt.c
> +++ b/drivers/watchdog/da9052_wdt.c
> @@ -215,14 +215,14 @@ static int da9052_wdt_probe(struct platform_device *pdev)
> goto err;
> }
>
> - dev_set_drvdata(&pdev->dev, driver_data);
> + platform_set_drvdata(pdev, driver_data);
> err:
> return ret;
> }
>
> static int da9052_wdt_remove(struct platform_device *pdev)
> {
> - struct da9052_wdt_data *driver_data = dev_get_drvdata(&pdev->dev);
> + struct da9052_wdt_data *driver_data = platform_get_drvdata(pdev);
>
> watchdog_unregister_device(&driver_data->wdt);
> kref_put(&driver_data->kref, da9052_wdt_release_resources);
> --
> 1.7.10.4
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/5] watchdog: da9052: use platform_{get,set}_drvdata()
2013-05-23 10:44 [PATCH 2/5] watchdog: da9052: use platform_{get,set}_drvdata() Jingoo Han
2013-05-24 14:58 ` Guenter Roeck
@ 2013-05-26 13:36 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Wim Van Sebroeck @ 2013-05-26 13:36 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', linux-kernel, linux-watchdog,
'Guenter Roeck'
Hi Jingoo,
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/watchdog/da9052_wdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Patch added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-26 13:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-23 10:44 [PATCH 2/5] watchdog: da9052: use platform_{get,set}_drvdata() Jingoo Han
2013-05-24 14:58 ` Guenter Roeck
2013-05-26 13:36 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox