* [PATCH 40/42] rtc: rtc-puv3: remove unnecessary platform_set_drvdata()
@ 2013-05-03 6:39 Jingoo Han
2013-05-03 16:30 ` Xuetao Guan
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-03 6:39 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Alessandro Zummo', rtc-linux, Jingoo Han,
'Guan Xuetao'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/rtc/rtc-puv3.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
index 72f4371..402732c 100644
--- a/drivers/rtc/rtc-puv3.c
+++ b/drivers/rtc/rtc-puv3.c
@@ -224,7 +224,6 @@ static int puv3_rtc_remove(struct platform_device *dev)
{
struct rtc_device *rtc = platform_get_drvdata(dev);
- platform_set_drvdata(dev, NULL);
rtc_device_unregister(rtc);
puv3_rtc_setpie(&dev->dev, 0);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 40/42] rtc: rtc-puv3: remove unnecessary platform_set_drvdata()
2013-05-03 6:39 [PATCH 40/42] rtc: rtc-puv3: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-03 16:30 ` Xuetao Guan
0 siblings, 0 replies; 2+ messages in thread
From: Xuetao Guan @ 2013-05-03 16:30 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', linux-kernel, 'Alessandro Zummo',
rtc-linux, Jingoo Han, 'Guan Xuetao'
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Thanks.
Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
> ---
> drivers/rtc/rtc-puv3.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
> index 72f4371..402732c 100644
> --- a/drivers/rtc/rtc-puv3.c
> +++ b/drivers/rtc/rtc-puv3.c
> @@ -224,7 +224,6 @@ static int puv3_rtc_remove(struct platform_device
> *dev)
> {
> struct rtc_device *rtc = platform_get_drvdata(dev);
>
> - platform_set_drvdata(dev, NULL);
> rtc_device_unregister(rtc);
>
> puv3_rtc_setpie(&dev->dev, 0);
> --
> 1.7.2.5
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-03 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-03 6:39 [PATCH 40/42] rtc: rtc-puv3: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-03 16:30 ` Xuetao Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox