* [PATCH 1/8] 88pm860x_battery: remove unnecessary platform_set_drvdata()
@ 2013-05-06 4:16 Jingoo Han
2013-06-07 0:17 ` Anton Vorontsov
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 4:16 UTC (permalink / raw)
To: 'Anton Vorontsov'
Cc: 'David Woodhouse', linux-kernel, 'Jingoo Han',
'Jett.Zhou'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/power/88pm860x_battery.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/power/88pm860x_battery.c b/drivers/power/88pm860x_battery.c
index d338c1c..dfcda3a 100644
--- a/drivers/power/88pm860x_battery.c
+++ b/drivers/power/88pm860x_battery.c
@@ -992,7 +992,6 @@ static int pm860x_battery_remove(struct platform_device *pdev)
free_irq(info->irq_batt, info);
free_irq(info->irq_cc, info);
power_supply_unregister(&info->battery);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/8] 88pm860x_battery: remove unnecessary platform_set_drvdata()
2013-05-06 4:16 [PATCH 1/8] 88pm860x_battery: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-06-07 0:17 ` Anton Vorontsov
0 siblings, 0 replies; 2+ messages in thread
From: Anton Vorontsov @ 2013-06-07 0:17 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'David Woodhouse', linux-kernel, 'Jett.Zhou'
On Mon, May 06, 2013 at 01:16:30PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
1-8 applied, thanks a lot!
Anton
> ---
> drivers/power/88pm860x_battery.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/power/88pm860x_battery.c b/drivers/power/88pm860x_battery.c
> index d338c1c..dfcda3a 100644
> --- a/drivers/power/88pm860x_battery.c
> +++ b/drivers/power/88pm860x_battery.c
> @@ -992,7 +992,6 @@ static int pm860x_battery_remove(struct platform_device *pdev)
> free_irq(info->irq_batt, info);
> free_irq(info->irq_cc, info);
> power_supply_unregister(&info->battery);
> - platform_set_drvdata(pdev, NULL);
> return 0;
> }
>
> --
> 1.7.2.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-07 0:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 4:16 [PATCH 1/8] 88pm860x_battery: remove unnecessary platform_set_drvdata() Jingoo Han
2013-06-07 0:17 ` Anton Vorontsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox